This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
First Blood #1
Merged
First Blood #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mohanson
commented
Aug 14, 2019
mohanson
commented
- The main framework of compiler(Passed the Fibonacci test)
yejiayu
suggested changes
Aug 14, 2019
README.md
Outdated
|
|
||
| ``` | ||
| $ npm install | ||
| $ ts-node src/index.ts build tests/ts/application/fibonacci.ts |
src/index.ts
Outdated
| // [0] https://github.com/microsoft/TypeScript/wiki/Using-the-Compiler-API | ||
| // [1] https://github.com/microsoft/TypeScript/blob/master/doc/spec.md | ||
|
|
||
| import * as child_process from 'child_process'; |
There was a problem hiding this comment.
suggest removing *，
import x from 'xxx';
| @@ -0,0 +1,31 @@ | |||
| import os | |||
There was a problem hiding this comment.
Can you change the test to ave? Remove python code.
package.json
Outdated
| "commander": "^3.0.0", | ||
| "llvm-node": "^2.1.0", | ||
| "typescript": "^3.5.3", | ||
| "yarn": "^1.17.3" |
There was a problem hiding this comment.
If you want to do this globally, you should execute npm i -g yarn.
src/index.ts
Outdated
| } | ||
|
|
||
| function mainRun(): void { | ||
| if (typeof argv.output === 'undefined') { |
| argv.output = '/tmp/minits.ll'; | ||
| } | ||
| mainBuild(); | ||
| const p = child_process.spawn('lli', [argv.output]); |
There was a problem hiding this comment.
What's the point of starting another process?
There was a problem hiding this comment.
Use lli to execute the LLVM IR.
src/codegen.ts
Outdated
| } | ||
|
|
||
| public genSourceFile(sourceFile: ts.SourceFile): void { | ||
| sourceFile.forEachChild(node => { |
There was a problem hiding this comment.
Suggested change
| sourceFile.forEachChild(node => { | |
| sourceFile.forEachChild(this.genNode） |
|
|
||
| public genNode( | ||
| node: ts.Node | ||
| ): llvm.Constant | llvm.Type | llvm.Value | undefined | void { |
There was a problem hiding this comment.
llvm.Type | llvm.Value | null
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.