Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Sort folder contents by type #37

Closed
africanforest opened this issue Feb 13, 2020 · 8 comments
Closed

[Feature] Sort folder contents by type #37

africanforest opened this issue Feb 13, 2020 · 8 comments
Labels
feature request New feature or request

Comments

@africanforest
Copy link

africanforest commented Feb 13, 2020

Currently, within folders, all items are sorted equally - alphabetically or by time, regardless of item type. This creates confusion when there are many different items in a folder. I think it would be useful if the items within a folder were basically ordered by type: i.e. first folders, then files, then pages:

Subfolder a
Subfolder b
Subfolder c
File a
File b
File c
Page a
Page b
Page c

What do you think?

@johnozbay johnozbay changed the title Sort items inside folders by type [Feature] Sort folder contents by type Feb 19, 2020
@johnozbay johnozbay added the feature request New feature or request label Feb 19, 2020
@johnozbay
Copy link
Member

This a fantastic idea! Going to try and make this possible with the next update.

Two questions.

1) Sorting
For files, would you prefer if it's "All non document-files" (jpg, pdf etc) grouped together like and sorted alphabetically like :

Subfolder a
Subfolder b
Subfolder c
File a.pdf
File b.jpg
File c.pdf
File d.jpg
File e.xls
Doc a.crypteedoc
Doc b.crypteedoc
Doc c.crypteedoc

OR everything grouped based on extensions/filetypes like :

Subfolder a
Subfolder b
Subfolder c
File a.pdf
File b.pdf
File c.pdf
Photo a.jpg
Photo b.jpg
Photo c.jpg
Doc a.crypteedoc
Doc b.crypteedoc
Doc c.crypteedoc

2) Icon
What would you say is a good sort icon to represent file extensions / types?
For sorting based on recency/time, currently there's a clock icon.
For filenames, there's an A-Z icon.

Thanks a lot for this!

@africanforest
Copy link
Author

Glad that you accept my suggestion!

I think your second choice is the best solution:
Subfolder a
Subfolder b
Subfolder c
file a.pdf
file b.pdf
file c.pdf
Photo a.jpg
Photo b.jpg
Photo c.jpg
Doc a.crypteedoc
Doc b.crypteedoc
Doc c.crypteedoc

Maybe also this kind of sorting:

Subfolder a
Subfolder b
Subfolder c
Doc a.crypteedoc
Doc b.crypteedoc
Doc c.crypteedoc
file a.pdf
file b.pdf
file c.pdf
Photo a.jpg
Photo b.jpg
Photo c.jpg

The second question is particularly difficult to answer because the icon must be very small and must apply to all file types. Also, the same icon is often used for documents and files, and in this case it should be possible to distinguish between them.

This icon could be used for documents:

document_icon

And this one for files:

file_icon_01

Or maybe this one, but I don't think it can be downsized as much as necessary

file_icon_02

@johnozbay
Copy link
Member

Sounds good! I've added this to the to-do list! Going to try and add this in with the next update.

@johnozbay
Copy link
Member

johnozbay commented Feb 19, 2020

This is now ready, and will be shipped with the next update. For now I'm using a puzzle icon, and will keep thinking of a better alternative. (and will likely have some kind of AZ to it to indicate it's still sorting names, but based on extensions) – If the folder only has regular Cryptee documents, this becomes confusing (A-Z sorts twice basically, first based on filenames, second based on filenames among file-extensions)

Feel free to ping with suggestions. I've also considered using a pie-chart and cubes, but they're too wide and looks odd. (Same goes for puzzle, but it's flat left-side fits better with the arrow.

Screen Shot 2020-02-19 at 16 26 20

Screen Shot 2020-02-19 at 16 26 26

@johnozbay
Copy link
Member

One more update on this. Added some spacing and separators with extensions/filetypes to make it even easier to find the files you're looking for.

image

And needless to say the separators are only visible when sorted by filetype.

The icon is the only thing left bothering me. Will keep thinking.

@africanforest
Copy link
Author

That's great! The dividers are very effective, everything is very clear now, I really like that.
I guess the last selected sort is saved per folder?

@johnozbay
Copy link
Member

I guess the last selected sort is saved per folder?

Correct! They [already] are. (If for some reason this isn't the case let me know. That would mean the subfolders update broke something)

@johnozbay
Copy link
Member

Thanks folks! Added this with this month's update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants