Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LICENSE file to repo #10

Closed

Conversation

janhagen
Copy link

No description provided.

@janhagen janhagen closed this Oct 27, 2015
@janhagen janhagen reopened this Oct 27, 2015
@dcousens
Copy link
Member

Same points of discussion as were made in browserify/browserify-rsa#4.

Copyright (c) 2014-2015 JP Richardson & contributors

Would probably be best.
The date needs to be current (2015).
Please use the the MIT license text formatted as in https://github.com/crypto-browserify/browserify-rsa/pull/4/files.

@janhagen
Copy link
Author

All valid points.
I'll happily change to the MIT license instead but the current README file 'sort of' indicates a BSD license. My updated pull request therefore changes the README.md as well.

@dcousens
Copy link
Member

@jprichardson can you chime in, did you prefer the BSD license for any reason?

@jprichardson
Copy link
Member

@jprichardson can you chime in, did you prefer the BSD license for any reason?

Yes, because most of the code was extracted from CryptoJS which is licensed BSD v3. So rather than consider the legal issues of relicensing, I just stuck with the same license.

I don't know to what degree a person can relicense code? If it's changed 10%? 80%? Never?

@dcousens
Copy link
Member

You'd have to basically delete the code, and re-implement the algorithm from scratch. That is, without reference. IANAL.

I'll probably have to re-write it anyway, and I'll just adopt the code from sha.js and source the algorithm from a reference paper.
At that point, it should be fine?

@jprichardson
Copy link
Member

At that point, it should be fine?

I'd think it'd be fine legally, it's also fine by me.

But I must ask, why not just stick with the BSDv3? We know the lib is working and reimplementing an algorithm just to convert to MIT (from BSDv3) doesn't feel like the best use of time. Is the BSDv3 restricting us in some way?

@janhagen
Copy link
Author

I'm pretty sure the BSD3-Clause lets you license your work under whatever License you want. It is not like the copyleft licenses associated with the GPL.
So long as you acknowledge the fact that you've used BSD3-Clause licensed code to build your stuff (by including the original author's names and the standard text required by the license somewhere in your code) you can license your contributions/code under whatever terms you want.

Compare with the Apple license acknowledgement files. Those things are massive....

An example can be found here: http://www.apple.com/legal/internet-services/maps/oss-acknowledgements/ but there are others. For instance one distributed with Final Cut Pro.

Yet another pull request adds an ACKNOWLEDGEMENT file to the repo.

@fanatid
Copy link
Contributor

fanatid commented Apr 12, 2016

license was changed :)
please create new PR if you still want add this file

@fanatid fanatid closed this Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants