Indicate byte array inputs are supported too #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to write a wrapper function in my application that adds support for that, but noticed that it already does support that - the input is processed by
bytesToWords
, which works well with byte arrays. I updated the README to indicate that.One other thing that should perhaps be looked into is the different APIs that the SHA256 and RIPEMD160 modules expose. SHA256 can return multiple formats, but doesn't support Buffers, while RIPEMD160 only returns buffers. It probably makes sense to unify the interfaces (imho, I think its best to always return buffers and let the user handle other formats in app-land), but it'll probably break some code that depends on that.