This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem:(fix #1148) default deposit client-cli flow is complex #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linfeng-crypto
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
- Coverage 63.83% 63.78% -0.05%
==========================================
Files 149 149
Lines 19886 19900 +14
==========================================
- Hits 12694 12693 -1
- Misses 7192 7207 +15
|
devashishdxt
approved these changes
Mar 2, 2020
yihuang
approved these changes
Mar 2, 2020
|
bors r+ |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution:
deposit-amountcommandinputsto a staking address in--advancedmode