Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem (Fix #1222): non-enclave / public transactions don't have a common outer type #1258

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 17, 2020

Solution:

  • Change the structure of TxAux

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1258 into master will increase coverage by 0.01%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
+ Coverage   63.76%   63.77%   +0.01%     
==========================================
  Files         154      154              
  Lines       20332    20352      +20     
==========================================
+ Hits        12964    12979      +15     
- Misses       7368     7373       +5
Impacted Files Coverage Δ
cro-clib/src/types.rs 0% <ø> (ø) ⬆️
cro-clib/src/transaction_staking.rs 0% <0%> (ø) ⬆️
client-common/src/tendermint/types.rs 12% <0%> (ø) ⬆️
cro-clib/src/transaction.rs 0% <0%> (ø) ⬆️
...work/src/network_ops/default_network_ops_client.rs 75.36% <100%> (+0.27%) ⬆️
test-common/src/chain_env.rs 94.01% <100%> (ø) ⬆️
chain-abci/src/app/mod.rs 82.51% <100%> (ø) ⬆️
chain-abci/tests/abci_app.rs 95.07% <100%> (ø) ⬆️
chain-core/src/tx/mod.rs 59.25% <43.75%> (-0.86%) ⬇️
chain-abci/src/storage/mod.rs 74.52% <60%> (-0.17%) ⬇️
... and 7 more

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right -- would be good to add an entry to breaking changes in changelog

…t have a common outer type

Solution:
- Change the structure of TxAux
@yihuang
Copy link
Collaborator Author

yihuang commented Mar 18, 2020

looks all right -- would be good to add an entry to breaking changes in changelog

Done

@yihuang yihuang requested a review from tomtau March 18, 2020 03:56
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 18, 2020

@bors bors bot merged commit 78826e5 into crypto-com:master Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants