Problem: slightly slow hash function (fixes #1111) #1325

tomtau · 2020-03-30T10:15:44Z

Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on;
blake3 is relatively similar and includes these techniques by default)

blake3 used in message digest (txid) + trie hasher
~~simplified merkle tree code with keyed hashes~~
simplified client-* derivation code with derive_key mode (instead of that old hmac combo code)

NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files

CHANGELOG.md

tomtau · 2020-03-30T10:23:15Z

bors try

bors · 2020-03-30T10:42:57Z

try

Build failed

drone-hw/push

chain-core/src/common/merkle_tree.rs

codecov · 2020-03-31T02:50:30Z

Codecov Report

Merging #1325 into master will decrease coverage by 0.32%.
The diff coverage is 98.75%.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   63.58%   63.26%   -0.33%     
==========================================
  Files         152      152              
  Lines       20674    20656      -18     
==========================================
- Hits        13146    13067      -79     
- Misses       7528     7589      +61

Impacted Files	Coverage Δ
client-core/src/wallet/syncer.rs	`53.39% <ø> (-15.64%)`	⬇️
client-core/src/service/hd_key_service.rs	`83.07% <ø> (ø)`	⬆️
chain-core/src/tx/mod.rs	`62.43% <ø> (ø)`	⬆️
client-rpc/src/rpc/wallet_rpc.rs	`62.62% <ø> (ø)`	⬆️
client-common/src/seckey.rs	`93.18% <100%> (ø)`	⬆️
chain-core/src/state/account.rs	`75.6% <100%> (+0.06%)`	⬆️
chain-core/src/state/mod.rs	`91.89% <100%> (-2.71%)`	⬇️
chain-core/src/init/params.rs	`71.6% <100%> (ø)`	⬆️
chain-core/src/common/merkle_tree.rs	`98.76% <100%> (+0.21%)`	⬆️
chain-core/src/lib.rs	`91.66% <100%> (ø)`	⬆️
... and 8 more

devashishdxt

Resolve merge conflicts
Squash commits

tomtau · 2020-03-31T03:11:33Z

bors r+

1325: Problem: slightly slow hash function (fixes #1111) r=tomtau a=tomtau Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on; blake3 is relatively similar and includes these techniques by default) - blake3 used in message digest (txid) + trie hasher - simplified merkle tree code with keyed hashes - simplified client-* derivation code with `derive_key` mode (instead of that old hmac combo code) NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

bors · 2020-03-31T03:23:18Z

Build failed

drone-hw/push

tomtau · 2020-03-31T03:38:02Z

bors retry

1325: Problem: slightly slow hash function (fixes #1111) r=tomtau a=tomtau Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on; blake3 is relatively similar and includes these techniques by default) - blake3 used in message digest (txid) + trie hasher - ~~simplified merkle tree code with keyed hashes~~ - simplified client-* derivation code with `derive_key` mode (instead of that old hmac combo code) NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

bors · 2020-03-31T04:09:35Z

Canceled

tomtau · 2020-03-31T04:09:50Z

bors retry

1325: Problem: slightly slow hash function (fixes #1111) r=tomtau a=tomtau Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on; blake3 is relatively similar and includes these techniques by default) - blake3 used in message digest (txid) + trie hasher - ~~simplified merkle tree code with keyed hashes~~ - simplified client-* derivation code with `derive_key` mode (instead of that old hmac combo code) NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

… change Solution: updated as per crypto-com/thaler#1325

… change (#118) Solution: updated as per crypto-com/thaler#1325

bors · 2020-03-31T05:08:23Z

Build failed

continuous-integration/travis-ci/push

devashishdxt

Update integration tests

tomtau · 2020-03-31T05:32:59Z

bors retry

1325: Problem: slightly slow hash function (fixes #1111) r=tomtau a=tomtau Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on; blake3 is relatively similar and includes these techniques by default) - blake3 used in message digest (txid) + trie hasher - ~~simplified merkle tree code with keyed hashes~~ - simplified client-* derivation code with `derive_key` mode (instead of that old hmac combo code) NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

Solution: switched to blake3, as blake2s was more of a temporary choice (it was planned to use e.g. blake2sp later on; blake3 is relatively similar and includes these techniques by default) - blake3 used in message digest (txid) + trie hasher - simplified merkle tree code with hashers instead of intermediate vectors - simplified client-* derivation code with `derive_key` mode (instead of that old hmac combo code) NOTE: one syncer test is broken and ignored for the moment, as it'd require regeneration of asset files

bors · 2020-03-31T05:58:00Z

Canceled

tomtau · 2020-03-31T05:58:17Z

bors retry

bors · 2020-03-31T06:55:53Z

Build succeeded

tomtau requested review from yihuang, calvinaco, devashishdxt, leejw51crypto and linfeng-crypto March 30, 2020 10:15

yihuang reviewed Mar 30, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

yihuang reviewed Mar 30, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tomtau force-pushed the switch/blake3 branch from d8559f2 to 419757c Compare March 30, 2020 10:22

bors bot added a commit that referenced this pull request Mar 30, 2020

Try #1325:

ae66995

yihuang approved these changes Mar 30, 2020

View reviewed changes

devashishdxt reviewed Mar 31, 2020

View reviewed changes

chain-core/src/common/merkle_tree.rs Show resolved Hide resolved

devashishdxt approved these changes Mar 31, 2020

View reviewed changes

tomtau force-pushed the switch/blake3 branch from d9b15be to 4671c5e Compare March 31, 2020 03:08

tomtau force-pushed the switch/blake3 branch from 4671c5e to 7866944 Compare March 31, 2020 03:37

tomtau force-pushed the switch/blake3 branch from 7866944 to 377843d Compare March 31, 2020 04:09

tomtau added a commit to tomtau/chain-docs that referenced this pull request Mar 31, 2020

Problem: hash function doesn't match the one in the stabilized format…

286767c

… change Solution: updated as per crypto-com/thaler#1325

tomtau mentioned this pull request Mar 31, 2020

Problem: hash function doesn't match the one in the stabilized format change crypto-com/thaler-docs#118

Merged

tomtau added a commit to crypto-com/thaler-docs that referenced this pull request Mar 31, 2020

Problem: hash function doesn't match the one in the stabilized format…

54b11da

… change (#118) Solution: updated as per crypto-com/thaler#1325

devashishdxt suggested changes Mar 31, 2020

View reviewed changes

tomtau force-pushed the switch/blake3 branch from 377843d to d01e005 Compare March 31, 2020 05:32

tomtau force-pushed the switch/blake3 branch from d01e005 to 2f704ef Compare March 31, 2020 05:57

bors bot merged commit ba4a09d into crypto-com:master Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem: slightly slow hash function (fixes #1111) #1325

Problem: slightly slow hash function (fixes #1111) #1325

tomtau commented Mar 30, 2020 •

edited by devashishdxt

tomtau commented Mar 30, 2020

bors bot commented Mar 30, 2020

codecov bot commented Mar 31, 2020 •

edited

devashishdxt left a comment •

edited by tomtau

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

devashishdxt left a comment •

edited by tomtau

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Problem: slightly slow hash function (fixes #1111) #1325

Problem: slightly slow hash function (fixes #1111) #1325

Conversation

tomtau commented Mar 30, 2020 • edited by devashishdxt

tomtau commented Mar 30, 2020

bors bot commented Mar 30, 2020

try

Build failed

codecov bot commented Mar 31, 2020 • edited

Codecov Report

devashishdxt left a comment • edited by tomtau

Choose a reason for hiding this comment

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Build failed

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Canceled

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Build failed

devashishdxt left a comment • edited by tomtau

Choose a reason for hiding this comment

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Canceled

tomtau commented Mar 31, 2020

bors bot commented Mar 31, 2020

Build succeeded

tomtau commented Mar 30, 2020 •

edited by devashishdxt

codecov bot commented Mar 31, 2020 •

edited

devashishdxt left a comment •

edited by tomtau

devashishdxt left a comment •

edited by tomtau