Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem (Fix #1308): unnecessary item wrappers for merkle trie storage #1428

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 14, 2020

Solution:

  • Do the switch to jellyfish merkle library.

@tomtau
Copy link
Contributor

tomtau commented Apr 14, 2020

bors try

bors bot added a commit that referenced this pull request Apr 14, 2020
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for historical reasons, chain-abci aggregated some unused dependencies -- it still contains starling: https://github.com/crypto-com/chain/blob/master/chain-abci/Cargo.toml#L28 so can be removed ?

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 14, 2020

for historical reasons, chain-abci aggregated some unused dependencies -- it still contains starling: https://github.com/crypto-com/chain/blob/master/chain-abci/Cargo.toml#L28 so can be removed ?

Done

@bors
Copy link
Contributor

bors bot commented Apr 14, 2020

try

Build failed:

…rie storage

Solution:
- Do the switch to jellyfish merkle library.
@tomtau
Copy link
Contributor

tomtau commented Apr 14, 2020

bors r+

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #1428 into master will decrease coverage by 0.51%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
- Coverage   64.42%   63.90%   -0.52%     
==========================================
  Files         161      159       -2     
  Lines       21647    21143     -504     
==========================================
- Hits        13946    13512     -434     
+ Misses       7701     7631      -70     
Impacted Files Coverage Δ
chain-abci/src/main.rs 0.00% <ø> (ø)
chain-abci/src/storage/mod.rs 87.85% <ø> (+1.55%) ⬆️
chain-abci/src/app/query.rs 61.59% <80.00%> (+1.01%) ⬆️
chain-abci/src/app/app_init.rs 77.57% <81.81%> (+1.82%) ⬆️
chain-abci/src/app/commit.rs 95.08% <100.00%> (+0.16%) ⬆️
chain-abci/src/app/end_block.rs 100.00% <100.00%> (ø)
chain-abci/src/app/macros.rs 100.00% <100.00%> (ø)
chain-abci/src/app/mod.rs 82.10% <100.00%> (-0.10%) ⬇️
chain-abci/src/app/rewards.rs 98.27% <100.00%> (-0.02%) ⬇️
chain-abci/src/app/validate_tx.rs 83.09% <100.00%> (-0.24%) ⬇️
... and 13 more

@bors
Copy link
Contributor

bors bot commented Apr 14, 2020

Build succeeded:

@bors bors bot merged commit 2da10e8 into crypto-com:master Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants