Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: make test occurred some errors #137

Closed
SHH-HaoZhang opened this issue Feb 7, 2022 · 7 comments · Fixed by #140
Closed

Problem: make test occurred some errors #137

SHH-HaoZhang opened this issue Feb 7, 2022 · 7 comments · Fixed by #140
Assignees

Comments

@SHH-HaoZhang
Copy link
Contributor

Compiling defi-wallet-core-wasm v0.1.0 (.../defi-wallet-core-rs/bindings/wasm)
error[E0658]: macro attributes in #[derive] output are unstable
--> bindings/wasm/src/lib.rs:22:3
|
22 | #[wasm_bindgen]
| ^^^^^^^^^^^^
|
= note: see issue #81119 rust-lang/rust#81119 for more information

For more information about this error, try rustc --explain E0658.
error: could not compile defi-wallet-core-wasm due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed
make: *** [test] Error 101

@tomtau
Copy link
Contributor

tomtau commented Feb 7, 2022

@SHH-HaoZhang what version of the Rust compiler are you using?

@SHH-HaoZhang
Copy link
Contributor Author

rustc 1.56.1 (59eed8a2a 2021-11-01)

@stevenatcrypto
Copy link
Collaborator

I am using asdf-rust to manage multiple versions of Rust. I am installing 1.56.1 and will give a try.

@SHH-HaoZhang
Copy link
Contributor Author

No problem after upgrading to 1.58

@tomtau
Copy link
Contributor

tomtau commented Feb 7, 2022

maybe we can declare the minimum Rust version in Cargo.toml: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field ?

@stevenatcrypto
Copy link
Collaborator

maybe we can declare the minimum Rust version in Cargo.toml: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field ?

Should we just add a rust-toolchain file to specify a rust version as other projects?

Document: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

https://github.com/cosmos/cosmos-rust/blob/main/rust-toolchain
https://github.com/tikv/tikv/blob/master/rust-toolchain

@tomtau
Copy link
Contributor

tomtau commented Feb 7, 2022

yeah, rust-toolchain can be added as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants