New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad naming getGlobalInfo #94

Open

ghost opened this issue Nov 6, 2018 · 0 comments

Assignees

ghost commented Nov 6, 2018 •

edited by ghost

It never returns anything. Instead it updates global info, which is a variable. So it should not be called as "get".
It is an async function, should have a suffix "Async".

Notice that a lot of other functions also have bad naming convension.

lychees assigned flyq and Deasoso and unassigned flyq

lychees assigned coneycode and webkonglong and unassigned Deasoso and coneycode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment