Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: integration test speed is slow #197

Closed
leejw51crypto opened this issue Oct 20, 2020 · 4 comments
Closed

Problem: integration test speed is slow #197

leejw51crypto opened this issue Oct 20, 2020 · 4 comments

Comments

@leejw51crypto
Copy link
Contributor

currently, same test is done twice.

nix-integration-test: check-network
nix-shell integration_tests/shell.nix --run "pytest -v -n 3 -m 'not ledger' --dist loadscope"
nix-shell integration_tests/shell.nix --run "pytest -v -m ledger"

i suggest separate ledger and non-lendger to different folders,
so ,it makes total integration test faster

@yihuang
Copy link
Collaborator

yihuang commented Oct 20, 2020

it's separated by marks, "not ledger" and "ledger", they are not overlapped.

@yihuang
Copy link
Collaborator

yihuang commented Oct 21, 2020

currently ledger tests are running sequentially with other tests, the reason for that is ledger simulator is too costly, slows down the whole github action vm.

@yihuang
Copy link
Collaborator

yihuang commented Nov 3, 2020

I increased xdist's worker number to 7, the time dropped a bit.
pytest-xdist's scheduling strategy could also have some optimization, currently it treat fast and slow test cases as the same, if we can distribute slow test cases more evenly on workers, we could further shorten the total test running time. pytest-dev/pytest-xdist#255

@tomtau
Copy link
Contributor

tomtau commented Feb 25, 2021

it looks like the speed has been a bit improved, but has to be balanced, so that it doesn't timeout on CI -- feel free to reopen this if there's some obvious way for more improvements

@tomtau tomtau closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants