Integrate DCRDEX for DEX onboarding page #238

ukane-philemon · 2023-11-04T23:25:20Z

closes #209

Depends on #208

Note for reviewers:

This MR does not implement the required methods to make our existing assets compatible with dex core wallet interface https://github.com/decred/dcrdex/blob/master/client/asset/interface.go. That will be achieved in a separate PR.
Actual bond posting depends on 1 above.

config.go

log.go

config.go

go.mod

dexcore/core.go

wallet/wallet.go

itswisdomagain

Taking a pause, to go again after these.

dexcore/core.go

ui/page/dcrdex/dcrdex_page.go

libwallet/assets_manager.go

main.go

run_tests.sh

ui/page/dcrdex/dcrdex_page.go

ui/page/root/home_page.go

ui/page/root/trade_page.go

itswisdomagain

Looks like progress. Another review round.

Also, this PR title needs some love. It's implementing some dex functionality (specify), not adding live data to dex onboarding, as though there's some data somewhere that is being read and populated into the UI.

dexcore/core.go

ui/page/dcrdex/dex_onboarding_page.go

libwallet/assets_manager.go

ui/page/components/bottom_nav.go

ui/page/root/wallet_selector_page.go

dreacot · 2023-12-06T02:56:56Z

after i click start trading, i'm taken to the dex main page

ukane-philemon · 2023-12-06T11:04:11Z

Updated and rebased.

JustinBeBoy

something happen when i click to recent order

bug1.mp4

Nothing happen when clicked to select dex server
validate input when add dex server

libwallet/assets_manager.go

ui/page/dcrdex/dcrdex_page.go

ukane-philemon · 2023-12-06T20:18:22Z

I’m having issues viewing the video and images atm but will get to it as soon as I can. Thanks for the reviews. RE 2: if there’s only one server what do you expect the dropdown should do when clicked? In other words, the only server listed is selected by default and nothing should be done when it's clicked.

something happen when i click to recent order

@JustinBeBoy, please create an issue cuz it's out of scope for this PR and I don have swaps to investigate with.

ukane-philemon · 2023-12-07T12:37:55Z

00de2a0 is a lil out of scope for this PR but maybe we can have it here @dreacot?

ukane-philemon · 2023-12-07T22:44:34Z

i get this after clicking next on the select server step

Uhmm, I test server has been offline for some time. I'll see if I can replace it with another test server.

JustinBeBoy · 2023-12-08T03:08:10Z

i get this after clicking next on the select server step

Uhmm, I test server has been offline for some time. I'll see if I can replace it with another test server.

please do it, I can't test the next step

ukane-philemon · 2023-12-08T16:08:33Z

Note to reviewers: You'll only be able to post bond with #269.

EDIT: @JustinBeBoy @dreacot please you can proceed with your review.

itswisdomagain

If you had an idea to put dexc in AssetsManager, let's do that. I think it can work now.

ui/page/dcrdex/dex_onboarding_page.go

ui/page/exchange/create_order_page.go

ui/values/strings.go

ui/values/localizable/en.go

ui/preference/list_preference.go

JustinBeBoy · 2023-12-12T16:38:40Z

@dreacot @ukane-philemon
I'm wondering if the back button can't go back, should it be here, and from step 2 can we go back to step 1?

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

ukane-philemon · 2023-12-12T19:15:57Z

I'm wondering if the back button can't go back, should it be here, and from step 2 can we go back to step 1?

Password is set the first time we try to onboard. Users that abandon the process can't set pass twice.

dreacot · 2023-12-12T19:58:58Z

I'm wondering if the back button can't go back, should it be here, and from step 2 can we go back to step 1?

Password is set the first time we try to onboard. Users that abandon the process can't set pass twice.

i think he is saying th eback button shouldn't be there since users can't go back to step 1

ukane-philemon · 2023-12-12T20:21:15Z

i think he is saying th eback button shouldn't be there since users can't go back to step 1

okay, what do you think?

dreacot · 2023-12-12T20:23:14Z

i think he is saying th eback button shouldn't be there since users can't go back to step 1

okay, what do you think?

let's leave it for now

resolved

itswisdomagain requested changes Nov 5, 2023

View reviewed changes

ukane-philemon commented Nov 6, 2023

View reviewed changes

wallet/wallet.go Outdated Show resolved Hide resolved

dreacot requested review from itswisdomagain, JustinBeBoy, Sirmorrison and JoeGruffins November 6, 2023 20:55

itswisdomagain requested changes Nov 8, 2023

View reviewed changes

ukane-philemon force-pushed the live-onboarding branch from b78c94c to 34b27db Compare November 9, 2023 18:33

itswisdomagain requested changes Nov 10, 2023

View reviewed changes

ukane-philemon force-pushed the live-onboarding branch 2 times, most recently from b0d7f8e to 2c18d00 Compare November 10, 2023 23:12

ukane-philemon requested a review from itswisdomagain November 12, 2023 07:33

itswisdomagain requested changes Nov 13, 2023

View reviewed changes

ukane-philemon changed the title ~~add live data to dex onboarding page and minor refactor~~ Implement integrate DCRDEX for DEX onboarding page Nov 13, 2023

ukane-philemon changed the title ~~Implement integrate DCRDEX for DEX onboarding page~~ Integrate DCRDEX for DEX onboarding page Nov 13, 2023

dreacot requested a review from itswisdomagain November 24, 2023 18:09

ukane-philemon force-pushed the live-onboarding branch from 167dbd4 to 90daa07 Compare November 24, 2023 18:20

ukane-philemon mentioned this pull request Nov 27, 2023

Add DEX support for Cryptopower DCR wallets #269

Merged

ukane-philemon force-pushed the live-onboarding branch from 90daa07 to 6c2b2d7 Compare November 30, 2023 15:06

JustinBeBoy requested changes Dec 5, 2023

View reviewed changes

libwallet/assets_manager.go Outdated Show resolved Hide resolved

ui/page/components/bottom_nav.go Outdated Show resolved Hide resolved

ui/page/root/wallet_selector_page.go Outdated Show resolved Hide resolved

ukane-philemon force-pushed the live-onboarding branch 4 times, most recently from ede2b91 to 36be33c Compare December 6, 2023 01:28

ukane-philemon force-pushed the live-onboarding branch from f5fe5e6 to e624bac Compare December 6, 2023 11:03

JustinBeBoy previously requested changes Dec 6, 2023

View reviewed changes

libwallet/assets_manager.go Outdated Show resolved Hide resolved

libwallet/assets_manager.go Outdated Show resolved Hide resolved

ui/page/dcrdex/dcrdex_page.go Show resolved Hide resolved

dreacot reopened this Dec 7, 2023

ukane-philemon mentioned this pull request Dec 8, 2023

Multi: Refactor MasterPage and PageStack #250

Closed

ukane-philemon force-pushed the live-onboarding branch from 8b980be to dd5ee71 Compare December 8, 2023 16:07

itswisdomagain previously requested changes Dec 11, 2023

View reviewed changes

ukane-philemon force-pushed the live-onboarding branch from dd5ee71 to 4db3d57 Compare December 12, 2023 15:06

dreacot approved these changes Dec 12, 2023

View reviewed changes

ukane-philemon added 11 commits December 12, 2023 20:13

add live data to dex onboarding page

e83c567

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

use sync map for dex bond fee buffer cache

c95bf90

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

fix rebase issues and lint error

7673f37

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

show onbaording page by default

f129fe9

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

review changes

1b30d6a

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

display cex splash page on frst visit and variable rename

b875eb6

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

refactor and improve dex onboarding server step

6dd04db

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

fix lint error

85eaf86

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

add working certs for dex testnet

dfbd69f

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

review changes

6c35186

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

add support to hide input label for password modal and fix typo

e7c49e6

Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>

ukane-philemon force-pushed the live-onboarding branch from 6930ec4 to e7c49e6 Compare December 12, 2023 19:14

dreacot approved these changes Dec 13, 2023

View reviewed changes

dreacot merged commit 4b1fe60 into crypto-power:master Dec 13, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate DCRDEX for DEX onboarding page #238

Integrate DCRDEX for DEX onboarding page #238

ukane-philemon commented Nov 4, 2023 •

edited by dreacot

itswisdomagain left a comment

itswisdomagain left a comment

dreacot commented Dec 6, 2023

ukane-philemon commented Dec 6, 2023

JustinBeBoy left a comment

ukane-philemon commented Dec 6, 2023 via email •

edited

ukane-philemon commented Dec 7, 2023

ukane-philemon commented Dec 7, 2023

JustinBeBoy commented Dec 8, 2023 •

edited

ukane-philemon commented Dec 8, 2023 •

edited

itswisdomagain left a comment

JustinBeBoy commented Dec 12, 2023 •

edited

ukane-philemon commented Dec 12, 2023

dreacot commented Dec 12, 2023

ukane-philemon commented Dec 12, 2023

dreacot commented Dec 12, 2023

Integrate DCRDEX for DEX onboarding page #238

Integrate DCRDEX for DEX onboarding page #238

Conversation

ukane-philemon commented Nov 4, 2023 • edited by dreacot

itswisdomagain left a comment

Choose a reason for hiding this comment

itswisdomagain left a comment

Choose a reason for hiding this comment

dreacot commented Dec 6, 2023

ukane-philemon commented Dec 6, 2023

JustinBeBoy left a comment

Choose a reason for hiding this comment

ukane-philemon commented Dec 6, 2023 via email • edited

ukane-philemon commented Dec 7, 2023

ukane-philemon commented Dec 7, 2023

JustinBeBoy commented Dec 8, 2023 • edited

ukane-philemon commented Dec 8, 2023 • edited

itswisdomagain left a comment

Choose a reason for hiding this comment

JustinBeBoy commented Dec 12, 2023 • edited

ukane-philemon commented Dec 12, 2023

dreacot commented Dec 12, 2023

ukane-philemon commented Dec 12, 2023

dreacot commented Dec 12, 2023

ukane-philemon commented Nov 4, 2023 •

edited by dreacot

ukane-philemon commented Dec 6, 2023 via email •

edited

JustinBeBoy commented Dec 8, 2023 •

edited

ukane-philemon commented Dec 8, 2023 •

edited

JustinBeBoy commented Dec 12, 2023 •

edited