remove listener helper code, channels and multiple goroutines #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
requested changes
Nov 6, 2023
There was a problem hiding this comment.
Good work!
I still see this error... To reproduce, navigate back and forth between the wallet selection page and the selected wallet page.
2023-11-06 23:32:28.887 [ERR] UI: No rate information available
2023-11-06 23:32:30.870 [ERR] UI: Error adding sync progress listener: listener_already_exist
2023-11-06 23:32:43.719 [ERR] UI: No rate information available
itswisdomagain
commented
Nov 8, 2023
| @@ -122,21 +111,21 @@ func (mp *MainPage) OnNavigatedTo() { | |||
| } | |||
|
|
|||
| if mp.CurrentPage() == nil { | |||
| mp.Display(info.NewInfoPage(mp.Load)) // TODO: Should pagestack have a start page? | |||
| mp.Display(info.NewInfoPage(mp.Load)) // TODO: Should pagestack have a start page? YES! | |||
There was a problem hiding this comment.
@ukane-philemon would you like to work on this?
There was a problem hiding this comment.
Yes. I have just 2 PRs under review.
ukane-philemon
approved these changes
Nov 9, 2023
itswisdomagain
force-pushed
the
bg-listeners
branch
from
fe2c7e2
to
786038e
Compare
dreacot
approved these changes
Nov 10, 2023
This was referenced Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.