Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cex page for mobile #323

Merged
merged 3 commits into from Dec 14, 2023
Merged

fix cex page for mobile #323

merged 3 commits into from Dec 14, 2023

Conversation

dreacot
Copy link
Member

@dreacot dreacot commented Dec 14, 2023 •
edited

closes #159
closes #285
closes #314
closes #193

Screenshot from 2023-12-13 19-41-54

NB: trade history page and max button functionality would be added via another PR

@dreacot dreacot marked this pull request as ready for review December 14, 2023 02:42
@dreacot dreacot force-pushed the cex_mobile branch 2 times, most recently from 19d0b72 to 953e21f Compare December 14, 2023 02:43
@dreacot dreacot mentioned this pull request Dec 14, 2023
Merged
JoeGruffins
JoeGruffins reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@JoeGruffins JoeGruffins left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but see this upon navigating to receive. This is the wallets page. Probably fine to ignore:
Screenshot_20231214_152936

@dreacot
Copy link
Member Author

dreacot commented Dec 14, 2023

Unrelated but see this upon navigating to receive. This is the wallets page. Probably fine to ignore:
Screenshot_20231214_152936

i'm guessing that is a restored wallet, it probably needs to complete syncing first, as address discovery is the last stage during sync for a restored wallet

JustinBeBoy
JustinBeBoy requested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@JustinBeBoy JustinBeBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please check Min max layout and Recent Order, why it can be -1?

image

  1. Seem like you missing text size for splash page
    b2

ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/order_list.go Outdated Show resolved Hide resolved
ui/page/components/order_list.go Outdated Show resolved Hide resolved
ui/page/components/order_list.go Outdated Show resolved Hide resolved
ui/page/components/order_list.go Outdated Show resolved Hide resolved
ui/page/exchange/create_order_page.go Show resolved Hide resolved
ui/page/exchange/create_order_page.go Outdated Show resolved Hide resolved
ui/page/exchange/create_order_page.go Outdated Show resolved Hide resolved
ui/page/root/overview_page.go Outdated Show resolved Hide resolved
ui/values/dimensions.go Outdated Show resolved Hide resolved
@dreacot
Copy link
Member Author

dreacot commented Dec 14, 2023

Recent Order, why it can be -1?

that's because of #93 @JustinBeBoy

@dreacot dreacot merged commit 0ce3579 into crypto-power:master Dec 14, 2023
1 check passed
@dreacot dreacot deleted the cex_mobile branch December 14, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeBoy JustinBeBoy JustinBeBoy requested changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

@ukane-philemon ukane-philemon Awaiting requested review from ukane-philemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dreacot @JustinBeBoy @JoeGruffins