Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout Send page and send modal for mobile version #347

Merged
merged 12 commits into from Dec 29, 2023

Conversation

JustinBeBoy
Copy link
Collaborator

@JustinBeBoy JustinBeBoy commented Dec 20, 2023

Resolves #289
Resolves #291
Resolves #344
Resolves #216

Screenshot

image

image

@dreacot
Copy link
Member

dreacot commented Dec 20, 2023

the send modal does not contain coin control(advanced options)

Screenshot from 2023-12-20 09-38-39

on the send modal, trying to select fetched rate from the fee api doesn't work
Screenshot from 2023-12-20 10-12-05

@dreacot
Copy link
Member

dreacot commented Dec 20, 2023

the entire coin selection row should be clickable, right now only the arrow is clickable
Screenshot from 2023-12-20 09-45-55

@dreacot
Copy link
Member

dreacot commented Dec 21, 2023

on the send modal, the margin between advanced options and description note is too long.

clicking on coin selection opens the coin selection page behind the modal, it should probably open up inside another modal

Screenshot from 2023-12-21 11-43-14

fee rate dropdown does not show for ltc on the send modal and on the send page

Screenshot from 2023-12-21 11-46-43

on mobile each amount field can take full width (look at centralized exchange page on mobile)
Screenshot from 2023-12-21 11-48-56

@JustinBeBoy
Copy link
Collaborator Author

on the send modal, the margin between advanced options and description note is too long.

clicking on coin selection opens the coin selection page behind the modal, it should probably open up inside another modal

Screenshot from 2023-12-21 11-43-14

fee rate dropdown does not show for ltc on the send modal and on the send page

Screenshot from 2023-12-21 11-46-43

on mobile each amount field can take full width (look at centralized exchange page on mobile) Screenshot from 2023-12-21 11-48-56

I need to research old logic,because the current logic is very different from what you asked for

@dreacot
Copy link
Member

dreacot commented Dec 22, 2023

on the send modal, the margin between advanced options and description note is too long.
clicking on coin selection opens the coin selection page behind the modal, it should probably open up inside another modal
Screenshot from 2023-12-21 11-43-14
fee rate dropdown does not show for ltc on the send modal and on the send page
Screenshot from 2023-12-21 11-46-43
on mobile each amount field can take full width (look at centralized exchange page on mobile) Screenshot from 2023-12-21 11-48-56

I need to research old logic,because the current logic is very different from what you asked for

can you elaborate? what part is going to be a problem?

@dreacot
Copy link
Member

dreacot commented Dec 27, 2023

the back button on the send modal doesn't work

Screenshot from 2023-12-27 11-19-46

the full text of the drop isn't showing
Screenshot from 2023-12-27 11-35-13

switching from address to wallet selects the same btc wallet and account, the account shouldn't be the same by default
Screenshot from 2023-12-27 11-48-12

@dreacot
Copy link
Member

dreacot commented Dec 29, 2023

fee rate dropdown does not show for ltc on the send modal and on the send page

this hasn't been fixed

@dreacot dreacot merged commit 0199d2e into crypto-power:master Dec 29, 2023
1 check passed
@JustinBeBoy JustinBeBoy deleted the send_page branch March 15, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants