Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded credentials from the code #2

Closed
stepansnigirev opened this issue Mar 22, 2022 · 1 comment · Fixed by #13
Closed

Remove hardcoded credentials from the code #2

stepansnigirev opened this issue Mar 22, 2022 · 1 comment · Fixed by #13

Comments

@stepansnigirev
Copy link
Collaborator

Currently, access token is hardcoded. We need to have an "AMP login page" when activating the extension.
I think it makes sense to have a login page that supports both username + password and token for login.
Access token can be stored in the user settings similar to Swan and other extensions.

@stepansnigirev
Copy link
Collaborator Author

encrypted file content can be like that:

{
   "liquidv1": "mainnet token",
   "liquidtestnet": "testnet token",
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant