Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show understandable error message if the vault.cryptomator-file is missing in vault version 8 #381

Closed
2 tasks done
SailReal opened this issue Nov 12, 2021 · 1 comment
Closed
2 tasks done
Labels
good first issue Issues easy to implement or with a narrow scope of changes type:bug Something isn't working
Milestone

Comments

@SailReal
Copy link
Member

Please agree to the following

Summary

As a user, I want to get a better error message if my vault.cryptomator file is missing

System Setup

- Android: x
- Cryptomator: 1.6.3

Cloud Type

No response

Steps to Reproduce

  1. Create a vault using Cryptomator 1.6.x
  2. Delete vault.cryptomator
  3. Unlock vault

Expected Behavior

User knows, that the vault.cryptomator file is missing

Actual Behavior

Reproducibility

Always

Relevant Log Output

D	20211111220706.532	UnlockVaultUsingMasterkeyUseCase	started 10d1eea7
D	20211111220707.075	UnlockVaultUsingMasterkeyUseCase	failed 10d1eea7
D	20211111220707.077	ExceptionHandler	Unexpected error
org.cryptomator.cryptolib.api.UnsupportedVaultFormatException: Tried to open vault of version 999, but can only handle version 7
	at org.cryptomator.data.cloud.crypto.MasterkeyCryptoCloudProvider.assertLegacyVaultVersionIsSupported(MasterkeyCryptoCloudProvider.kt:210)
	at org.cryptomator.data.cloud.crypto.MasterkeyCryptoCloudProvider.unlock(MasterkeyCryptoCloudProvider.kt:109)
	at org.cryptomator.data.cloud.crypto.CryptoCloudFactory.unlock(CryptoCloudFactory.java:68)
	at org.cryptomator.data.repository.CloudRepositoryImpl.unlock(CloudRepositoryImpl.java:110)
	at org.cryptomator.domain.usecases.vault.UnlockVaultUsingMasterkey.execute(UnlockVaultUsingMasterkey.java:42)
	at org.cryptomator.domain.usecases.vault.UnlockVaultUsingMasterkeyUseCase$Launcher$2.call(UnlockVaultUsingMasterkeyUseCase.java:117)
	at org.cryptomator.domain.usecases.vault.UnlockVaultUsingMasterkeyUseCase$Launcher$2.call(UnlockVaultUsingMasterkeyUseCase.java:111)
	at io.reactivex.internal.operators.flowable.FlowableFromCallable.subscribeActual(FlowableFromCallable.java:39)
	at io.reactivex.Flowable.subscribe(Flowable.java:14935)
	at io.reactivex.Flowable.subscribe(Flowable.java:14882)
	at io.reactivex.internal.operators.flowable.FlowableSubscribeOn$SubscribeOnSubscriber.run(FlowableSubscribeOn.java:82)
	at io.reactivex.internal.schedulers.ExecutorScheduler$ExecutorWorker$BooleanRunnable.run(ExecutorScheduler.java:288)
	at io.reactivex.internal.schedulers.ExecutorScheduler$ExecutorWorker.run(ExecutorScheduler.java:253)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:923)

ErrorCode: HDT2:CS1T

Anything else?

Due to the fact, that the vault version is 999, we know that there must exists a vault.cryptomator file

@SailReal SailReal added the type:bug Something isn't working label Nov 12, 2021
@SailReal SailReal added this to the Backlog milestone Nov 12, 2021
@SailReal SailReal changed the title Show understandable error message if the vault.cryptomator file is missing in vault version 8 Show understandable error message if the vault.cryptomator-file is missing in vault version 8 Nov 12, 2021
@SailReal SailReal added the good first issue Issues easy to implement or with a narrow scope of changes label Nov 16, 2021
@SailReal SailReal added this to To do in Good First Issues via automation Feb 10, 2022
@SailReal SailReal moved this from To do to In progress in Good First Issues Mar 15, 2022
@SailReal SailReal modified the milestones: Backlog, 1.8.0 Mar 15, 2022
@SailReal
Copy link
Member Author

Fixed in 0fc53f9

Good First Issues automation moved this from In progress to Done Mar 16, 2022
@SailReal SailReal modified the milestones: 1.8.0, 1.7.2 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues easy to implement or with a narrow scope of changes type:bug Something isn't working
Projects
Development

No branches or pull requests

1 participant