Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptomator on Windows assigns same drive letter to multiple vaults on start (and subsequently) #1900

Closed
2 tasks done
NixSar opened this issue Nov 5, 2021 · 3 comments
Closed
2 tasks done
Labels
os:windows type:bug Something isn't working
Milestone

Comments

@NixSar
Copy link

NixSar commented Nov 5, 2021

Please agree to the following

Summary

Cryptomator on Windows assigns same drive letter to multiple vaults, shows only one and usually refuses to lock it again with various errors. Subsequently, even manual mount to a different drive letter fails. Both vaults have automatically pick a suitable location ticked.

What software is involved?

  • Operating System: Windows 10 Pro x64 21H1
  • Cryptomator: 1.5.* up to 1.6.3
  • Dokany 1.5.*

Volume Type

Dokany

Steps to Reproduce

  1. Add multiple vaults to Cryptomator with the option Unlock vault when starting Cryptomator ticked
  2. Tick Launch Cryptomator on system start
  3. Restart system

Expected Behavior

All the vaults mounted on system start with different drive letters.

Actual Behavior

Two of the vaults always mount to the same drive letter and seemingly randomly only one of them is visible (browseable) to the user each time. Subsequently, locking one of the vaults gracefully always fails with drive in use message and sometimes force lock also fails with Error Code JLHE:MI7B:MI7B. When it doesn't fail and manages to lock again, manually mounting it again still mounts it to the same already assigned drive letter and the error cycle repeats.

Reproducibility

Always

Relevant Log Output

10:22:40.818 [main] INFO  org.cryptomator.launcher.Cryptomator - Starting Cryptomator 1.6.3 on Windows 10 10.0 (amd64)
10:22:40.867 [main] INFO  org.cryptomator.ipc.Server - Spawning IPC server listening on socket C:\Users\****\AppData\Roaming\Cryptomator\ipc.socket
10:22:41.411 [JavaFX Application Thread] INFO  o.c.ui.launcher.FxApplicationStarter - JavaFX Runtime started.
10:22:42.104 [App Background Thread 003] INFO  com.dokany.java.DokanyMount - Dokany API/driver version: 141 / 400
10:22:42.104 [App Background Thread 004] INFO  com.dokany.java.DokanyMount - Dokany API/driver version: 141 / 400
10:22:42.553 [JavaFX Application Thread] INFO  o.c.ui.unlock.UnlockWorkflow - Unlock of '*****' succeeded.
10:22:42.796 [JavaFX Application Thread] INFO  o.c.ui.unlock.UnlockWorkflow - Unlock of '*****' succeeded.
10:22:48.538 [JavaFX Application Thread] INFO  o.cryptomator.ui.common.VaultService - Revealed *****
10:23:09.745 [App Background Thread 006] INFO  com.dokany.java.DokanyMount - Unmounting dokan device at I:\
10:23:10.747 [dokanMount-2-main] INFO  org.cryptomator.common.vaults.Vault - Unmounted vault '******'
10:23:19.280 [JavaFX Application Thread] WARN  org.cryptomator.ui.lock.LockWorkflow - Lock of ****** failed.
org.cryptomator.common.vaults.LockNotCompletedException: Locking of vault ******* still in progress.
	at org.cryptomator.desktop@1.6.3/org.cryptomator.common.vaults.Vault.lock(Vault.java:183)
	at org.cryptomator.desktop@1.6.3/org.cryptomator.ui.lock.LockWorkflow.call(LockWorkflow.java:60)
	at org.cryptomator.desktop@1.6.3/org.cryptomator.ui.lock.LockWorkflow.call(LockWorkflow.java:31)
	at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Task.java:1426)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

Anything else?

No response

@NixSar NixSar added the type:bug Something isn't working label Nov 5, 2021
@overheadhunter
Copy link
Member

Seems to be a race condition, where the "available drive letters" aren't re-determined during each mount. Furthermore we need to make sure, that auto unlock during startup works in a strictly sequential order.

@infeo
Copy link
Member

infeo commented Nov 8, 2021

There are indicators for not being a "real" bug, but a misconfiguration:

When it doesn't fail and manages to lock again, manually mounting it again still mounts it to the same already assigned drive letter and the error cycle repeats.

@NixSar Did you every fixed the mountpoint of a vault to a certain drive letter? You can find the setting in the vault specific settings, tab "Mounting".

@NixSar
Copy link
Author

NixSar commented Nov 8, 2021

Mounting is and always was set to pick a suitable location, never a drive letter, so it is certainly a bug. Also, I have to add that after additional testing it appears the subsequent manual mounting to the same drive letter only occurs if I beforehand unmount the 'wrong' duplicate. I have to test more to see if the subsequent part of the bug occurs with unmouting the browseable or invisible drive.

@infeo infeo closed this as completed in 71b876b Jul 18, 2022
@infeo infeo added this to the 1.6.11 milestone Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:windows type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants