Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Google Drive Preset #2921

Open
2 tasks done
overheadhunter opened this issue May 23, 2023 · 0 comments · May be fixed by #3270
Open
2 tasks done

Improve Google Drive Preset #2921

overheadhunter opened this issue May 23, 2023 · 0 comments · May be fixed by #3270
Labels
good first issue Issues easy to implement or with a narrow scope of changes os:mac storage:google-drive type:enhancement Improvements on an existing feature

Comments

@overheadhunter
Copy link
Member

Please agree to the following

Summary

Auto detect all accounts and drives

Motivation

Currently, our GoogleDriveLocationPresetsProvider checks a hard-coded path ~/Google Drive/My Drive, which is partly incorrect (on non-english locales) and partly incomplete (when using multiple accounts or multiple drives per account) - see #2918 (comment).

Instead, we should look for ~/Library/CloudStorage/GoogleDrive-*/*. The display name should be composed of both the account name (first *) and the drive name (second *).

Considered Alternatives

No response

Anything else?

This would likely also solve issue #1930

We might need to refactor the UI to support a) longer display names and b) a longer list of found clouds.

Feel free to move this issue to integrations-mac, if the API has been externalized by the time you start working on it. 😉
@overheadhunter overheadhunter added type:enhancement Improvements on an existing feature storage:google-drive labels May 23, 2023
@overheadhunter overheadhunter mentioned this issue May 23, 2023
Merged
@infeo infeo added the good first issue Issues easy to implement or with a narrow scope of changes label Jul 3, 2023
@siard-y siard-y linked a pull request Jan 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues easy to implement or with a narrow scope of changes os:mac storage:google-drive type:enhancement Improvements on an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Google Drive Preset #2921 siard-y/cryptomator
2 participants
@overheadhunter @infeo