Cryptomator crashes on macOS when clicking outside the file picker dialog

[half0wl]

Basic Info

I'm using macOS Mojave 10.14.1 (18B75), running Cryptomator 1.4.0 (1229).

Description

Steps to reproduce:

1. Click + -> Create New Vault (or Open Existing Vault)

2. When the filepicker dialog shows, click anywhere that makes it lose focus (the desktop, other app windows, etc.)

3. Cryptomator crashes

Attachments

Relevant trace:

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGABRT)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000008
Exception Note:        EXC_CORPSE_NOTIFY

VM Regions Near 0x8:
--> 
    __TEXT                 000000010b445000-000000010b446000 [    4K] r-x/rwx SM=COW  /Applications/Cryptomator.app/Contents/MacOS/Cryptomator

Application Specific Information:
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: _type > 0 && _type <= kCGSLastEventType'
terminating with uncaught exception of type NSException
abort() called

Application Specific Backtrace 1:
0   CoreFoundation                      0x00007fff30ecde65 __exceptionPreprocess + 256
1   libobjc.A.dylib                     0x00007fff5cf28720 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff30ee8ab2 +[NSException raise:format:arguments:] + 98
3   Foundation                          0x00007fff3328cd1d -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 194
4   AppKit                              0x00007fff2e375029 -[NSEvent _initWithCGEvent:eventRef:] + 3272
5   AppKit                              0x00007fff2e6c874c +[NSEvent eventWithCGEvent:] + 120
6   libglass.dylib                      0x0000000117be120b listenTouchEvents + 59
7   SkyLight                            0x00007fff56fde41e _ZL19processEventTapDataPvjjjPhj + 148
8   SkyLight                            0x00007fff56edcc9e _XPostEventTapData + 278
9   SkyLight                            0x00007fff56fde32c _ZL22eventTapMessageHandlerP12__CFMachPortPvlS1_ + 132
10  CoreFoundation                      0x00007fff30e2e7cf __CFMachPortPerform + 282
11  CoreFoundation                      0x00007fff30e2e6a9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
12  CoreFoundation                      0x00007fff30e2e607 __CFRunLoopDoSource1 + 527
13  CoreFoundation                      0x00007fff30e16689 __CFRunLoopRun + 2574
14  CoreFoundation                      0x00007fff30e15a28 CFRunLoopRunSpecific + 463
15  Foundation                          0x00007fff3317c3ba -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 280
16  libglass.dylib                      0x0000000117bcdb25 +[GlassApplication enterNestedEventLoopWithEnv:] + 165
17  libglass.dylib                      0x0000000117bce5ba Java_com_sun_glass_ui_mac_MacApplication__1enterNestedEventLoopImpl + 74
18  ???                                 0x0000000117fc1b50 0x0 + 4697365328

---

Sidenote for anyone running into this - the crash causes this error to be thrown when trying to unlock vaults that were open at the time it crashed:

16:04:59.987 [JavaFX Application Thread] ERROR o.c.ui.controllers.UnlockController - Unlock failed for technical reasons.
java.nio.file.FileSystemException: /Users/ray/Library/Application Support/Cryptomator/<redacted_vault_name> -: Device not configured
	at java.base/sun.nio.fs.UnixException.translateToIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(Unknown Source)
	at java.base/java.nio.file.Files.newDirectoryStream(Unknown Source)
	at org.cryptomator.ui.model.FuseVolume.createDirIfNotExist(FuseVolume.java:63)
	at org.cryptomator.ui.model.FuseVolume.mount(FuseVolume.java:53)
	at org.cryptomator.ui.model.Vault.unlock(Vault.java:109)
	at org.cryptomator.ui.controllers.UnlockController.lambda$didClickUnlockButton$0(UnlockController.java:392)
	at org.cryptomator.ui.util.Tasks.lambda$create$0(Tasks.java:33)
	at org.cryptomator.ui.util.Tasks$TaskImpl.call(Tasks.java:139)
	at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

I was able to fix this by unmounting it and unlocking again:

$ ls -la ~/Library/Application\ Support/Cryptomator
$ umount ~/Library/Application\ Support/Cryptomator/<offending_vault>

[tobihagemann]

I mentioned this briefly in an unrelated issue: #701 (comment)

It's an upstream bug in JavaFX and will be resolved in their next update: https://bugs.openjdk.java.net/browse/JDK-8211304

After their release, we'll have to see when and how Cryptomator's dependencies are updated. It's currently not so trivial since the JDK 11 mess-up.

[tobihagemann]

Depends on #769

[overheadhunter]

Upstream bugfix currently scheduled for OpenJFX 12

[overheadhunter]

Since there is a backport for OpenJFX 11.0.2, this will be fixed with the next Cryptomator release.