Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong window title displayed in GNOME top bar #956

Open
gschaffner opened this issue Aug 22, 2019 · 6 comments
Open

Wrong window title displayed in GNOME top bar #956

gschaffner opened this issue Aug 22, 2019 · 6 comments

Comments

@gschaffner
Copy link

@gschaffner gschaffner commented Aug 22, 2019

Description

With GNOME 3.32.2, the wrong window title is displayed in the top bar when the Cryptomator window is focused.

System Setup

  • Operating system and version: Manjaro GNU/Linux 18.0.4 w/ GNOME 3.32
  • Cryptomator version: 1.4.15
  • Drive: FUSE

Steps to Reproduce

  1. Open Cryptomator GUI and observe the GNOME top bar.

Expected Behavior

Cryptomator will be displayed as the window's title.

Actual Behavior

org.cryptomator.launcher.Cryptomator$MainApp is displayed as the window's title.

Reproducibility

Always

Additional Information

This bug is occurring on a fresh Manjaro installation with no prior use of Cryptomator.

@bilelmoussaoui

This comment has been minimized.

Copy link

@bilelmoussaoui bilelmoussaoui commented Sep 4, 2019

It's due to a missing StartupWMClass key in the desktop file to allow GNOME Shell identify the application and display the right name.
Adding this to desktop file should fix it

StartupWMClass=skymatic-cryptomator
@overheadhunter

This comment has been minimized.

Copy link
Member

@overheadhunter overheadhunter commented Sep 4, 2019

@bilelmoussaoui

This comment has been minimized.

Copy link

@bilelmoussaoui bilelmoussaoui commented Sep 4, 2019

@overheadhunter I should have mentioned that the WMClass I used was the one from the flatpak package. Not sure if it's the correct one
CC @x80486

@dhet

This comment has been minimized.

Copy link

@dhet dhet commented Oct 5, 2019

I'm not sure if it's that simple. The StartupWMClass entry only provides a way to group windows of the same application together. It cannot be used to assign the WM class to an application.
One way to assign the WM class is via explicit gtk_window_set_wmclass() call (i.e. not possible from Java). I spend a few hours trying to find a way to do this with JavaFX but I couldn't find anything. Maybe the jpackager or appimagetool is worth a look?

Btw, in the current snapshot version the window title says "java" (see screenshot) and the WM class is also "java" which means that

  • window grouping as it is right now does not work
  • even if we set StartupWMClass=java, gnome will group all "java" applications under the Cryptomator icon
    (I tried plain JAR as well as AppImage)
    cryptomator-java
@tobihagemann

This comment has been minimized.

Copy link
Member

@tobihagemann tobihagemann commented Oct 5, 2019

Calling native functions is within the realm of possibility. 😉 We have already done that for Windows and macOS but it wasn't needed for Linux yet. But of course, if there is another (and much simpler) way, that would definitely be preferred.

@x80486

This comment has been minimized.

Copy link

@x80486 x80486 commented Oct 5, 2019

It's due to a missing StartupWMClass key in the desktop file to allow GNOME Shell identify the application and display the right name.
Adding this to desktop file should fix it

StartupWMClass=skymatic-cryptomator

Indeed, no problems with the Flatpak...check! 😎

Screenshot from 2019-10-05 16-30-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.