Add option to lock open vaults without asking for confirmation upon exit / shutdown

[hippotastic]

Summary

Please add a checkbox Always lock open vaults on exit (or similar) to the confirmation dialog that appears upon every exit / shutdown in Cryptomator 1.5.0 alpha 1 if any vaults are unlocked.

Motivation

I have configured Cryptomator to start with Windows and keep it running in the background all the time. During my daily work, I don't want to interact with Cryptomator at all and just have it provide a secure drive that's backed up through Dropbox. Before 1.5.0, this worked really well.

However, in 1.5.0 alpha 1, you seem to have added a confirmation dialog that appears during every exit / shutdown, even if there are no processes using any of the open vaults. This delays or even prevents a proper Windows shutdown and is just an annoyance requiring additional clicks. Also, if I'm closing my laptop and put it in my bag, it doesn't shut down and turn off anymore due to that unwanted confirmation dialog.

I realize that some users may want to confirm locking their vaults upon every exit / shutdown, but for those that don't, I would recommend adding a checkbox like Always lock open vaults on exit to the dialog to reduce frustration and shutdown issues like mine.

If the checkbox is checked, Cryptomator should just silently lock the open vaults and exit. With this configuration, the only reason a dialog may appear is if locking failed due to the drives being in use. In this case, it is appropriate to display a dialog, requiring user interaction. However, during shutdown, I would recommend retrying several times before displaying this dialog, as other processes that were using the vaults may need some time to terminate.

Considered Alternatives

• Keep it like it currently is:
  This forces users to manually close open vaults in Cryptomator before shutting down. If users forget about it (which is highly likely due to humans being forgetful), the shutdown problems described above persist.
• Completely remove the shutdown confirmation dialog:
  May leave some users wondering if their vaults were securely locked. The checkbox is therefore a preferred option.

[overheadhunter]

Adding a checkbox to start locking remaining vaults automatically is feasible.

However, we have to see if this can be done completely silent, i.e. without any visual feedback. This might lead to this "this app is not responding. force quit?" dialog in Windows, which defeats the whole purpose of using the deferred termination API.

---

Also, it is worth discussing if such an option has unwanted side effects. Unexperienced users might just enable this option without being fully aware of the risks of data losses due to incomplete writes.

After all, quitting Cryptomator is by no means the way users are supposed to lock vaults. Due to the fact that Cryptomator can not know which 3rd party processes are accessing a drive, locking should always be done explicitly. The implicit unmount on shutdown is just a last-resort attempt of resetting system resources.

[hippotastic]

The "this app is not responding. force quit?" dialog you mentioned currently appears for me 100% of the time due to Cryptomator not terminating and waiting for my confirmation that, yes, I really want to shut down.

Therefore, adding a checkbox to skip this confirmation would definitely improve this situation and limit it to the rare cases where locking takes longer than Windows allows before displaying the "not responding" message.

[overheadhunter]

Yes, but as a user you see why it is "not responding". I'm just saying that doing long-running operations without visual feedback is not a good idea.

[hippotastic]

I don't see that Cryptomator is blocking my shutdown from completing when I close the lid of my laptop to shut it down, but I get your point. :-)

Two ideas:

1. You could use the tray icon to give feedback about the closing process like Outlook does: The icon immediately becomes greyed out with a "closing" overlay and finally disappears as soon as closing has finished. This way, the user is informed in an unobtrusive manner about the progress.
2. If closing unexpectedly takes longer to complete, you could display the dialog only after a certain timeout has elapsed (ideally, this would be in sync with the Windows "not responding" timeout, which appears to be the value HungAppTimeout in HKEY_CURRENT_USER\Control Panel\Desktop).

[infeo]

Implemented with #2273. The option can be found in the general preferences.

[hippotastic]

Nice, thank you!