Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When claiming from many small balanceid, the transaction times out #456

Closed
xeroc opened this issue Nov 6, 2015 · 9 comments
Closed

When claiming from many small balanceid, the transaction times out #456

xeroc opened this issue Nov 6, 2015 · 9 comments
Assignees
Labels
Milestone

Comments

@xeroc
Copy link
Contributor

xeroc commented Nov 6, 2015

To prevent that, I would recommend to put the expiration time in the transaction only after the (unsigned) transaction is finalized

@wmbutler wmbutler added the bug label Nov 7, 2015
@wmbutler wmbutler added this to the 2.0.151111 milestone Nov 7, 2015
@wmbutler
Copy link
Contributor

This needs to be claimed and worked by someone. @valzav thoughts? Moving to 1118

@wmbutler wmbutler modified the milestones: 2.0.151118, 2.0.151111 Nov 12, 2015
@svk31
Copy link
Contributor

svk31 commented Nov 12, 2015

@jcalfee is best equipped to handle this.

@jcalfee
Copy link

jcalfee commented Nov 12, 2015

jcalfee
I increase the expiration time for about 1 sec per signature.
Also, I group balance claims in groups of 60 ..
so the trx does not become too large..

jcalfee [1:14 PM]
So did you have the issue more than maybe 2 weeks ago?

xeroc [1:14 PM]
i'd say so .. yes

@wmbutler
Copy link
Contributor

@jcalfee I assigned this to you as well. If you are able to get into the groove, please claim items you are working on. Thanks.

@xeroc
Copy link
Contributor Author

xeroc commented Nov 18, 2015

@xeroc xeroc reopened this Nov 18, 2015
@wmbutler
Copy link
Contributor

@jcalfee Can you squeeze this edge case in before the Milestone ends?

@xeroc
Copy link
Contributor Author

xeroc commented Nov 18, 2015

@wmbutler: James talked to me about this already and he had it fixed .. I think the case above may have another reason that needs investigation first .. wouldn't count on this being fixed today already as we need input first

@wmbutler
Copy link
Contributor

wmbutler commented Dec 2, 2015

ok, so I'll push it again, close it if you think it enough of an edge case to not worry about it.

@wmbutler wmbutler modified the milestones: 2.0.151209, 2.0.151202 Dec 2, 2015
@wmbutler wmbutler modified the milestones: 2.0.151216, 2.0.151209 Dec 10, 2015
@svk31 svk31 modified the milestones: 2.0.151216, 2.0.151223 Dec 18, 2015
@wmbutler
Copy link
Contributor

Closing due to no feedback for many months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants