-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings for witnesses to disable certain operation types #122
Comments
Am I wrong in my understanding that the op filtering functionality would fall under the witness_object? Where is the local setting of an individual witness node handled? |
This needs to be implemented carefully: if the operation being filtered is found while processing a block, it must be allowed. It can only be rejected in a new transaction. |
Related ancestor issue from BTS 0.x: bitshares/bitshares1-core#1147 |
@nathanhourt : The alternatives are:
If the scenario envisioned for using this is discovering an awful bug in an operation which requires witnesses to disable that op very quickly, it's likely a chain security issue. Which would mean the thing the old version would need to support with only a witness config change is being able to hardfork the operation out. If you merely censor it, then a single witness could still include the buggy op and compromise the chain. I.e., if you don't build on blocks that contain the op, then reconfiguring a majority of witnesses suffices to suppress the buggy op. If you do build on blocks that contain the op, the witness reconfiguration must be unanimous to suppress the buggy op. |
Right, so in general the question is whether it's better to fork the chain, or to censor the op as soon as possible. The answer to that question is highly situation-dependent, so should we allow either option and then decide on a case-by-case basis which alternative to go with? |
This issue was moved to bitshares/bitshares-core#34 |
In the event of an bug in certain operations, witnesses need the ability to respond quickly and filter transactions that contain those operations.
The text was updated successfully, but these errors were encountered: