Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_common can be made more efficient #3

Closed
emillon opened this issue Jun 27, 2016 · 1 comment
Closed

find_common can be made more efficient #3

emillon opened this issue Jun 27, 2016 · 1 comment

Comments

@emillon
Copy link
Contributor

emillon commented Jun 27, 2016

The current implementation builds a list of prefixes every time and checks if any is a suffix. It is possible to be better, either by precomputing the list of prefixes, or by building a suffix list.
@emillon emillon mentioned this issue Jun 27, 2016
Closed
@emillon
Copy link
Contributor Author

emillon commented Aug 9, 2016

According to the profiling done in #8 this seems good enough. Closing for now.

@emillon emillon closed this as completed Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emillon