Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded #12

Closed
metabaron opened this issue Oct 16, 2017 · 4 comments
Closed

Hardcoded #12

metabaron opened this issue Oct 16, 2017 · 4 comments

Comments

@metabaron
Copy link

https://github.com/AbenezerMamo/crypto-signal/blob/e46e8bd620631c8d20a1526d359c5af0a5f45b04/app.py#L22

I was wondering why some of the cryptocurrencies are not mine (from my wallet): you hardcoded the values.

I think you should propose: or to use the default values or to use the one from our wallet.

@bitcoinrate
Copy link

this is so you can decide which ones you want to track signals on, or add them all. It nothing about what's in your wallet.

@metabaron
Copy link
Author

ok so could I suggest something:
When the application start, or through a "--help" option, tell that to the user. Understand that most users are non-coders and they will NEVER check the code to understand, as I did, what is happening with the application.
Another way would be to have the pairs in a configuration file

@ghost
Copy link

ghost commented Oct 19, 2017

You can simply add more coins to the array or remove them as you wish. This is documented in the code.

@metabaron
Copy link
Author

I know I can do it. Not everyone read the code / understand code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants