Remove non-raising verification functions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all three (authenticators, signatures and boxes) will raise if there are errors in verifying them. This ensures that errors are dealt with, or the program comes crashing to a halt. Self-tests are also updated.
|
Some oddness with Travis running the tests. Looks like your branch is named Otherwise it looks good to me 👍 |
|
Tests now passed. Merging... |
tarcieri
added a commit
that referenced
this pull request
Nov 5, 2013
Remove non-raising verification functions
|
That was me changing branches, after a slightly careless squash merge confused things. Unfortunately, the other travis jobs were already queued. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all three (authenticators, signatures and boxes) will raise if there
are errors in verifying them. This ensures that errors are dealt with,
or the program comes crashing to a halt. Self-tests are also updated.