Allow RandomNonceBox to decrypt the same cipher text multiple times #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/cryptosphere/rbnacl/edit/master/lib/rbnacl/random_nonce_box.rb#L105 was preventing RandomNonceBox to open the same enciphered message multiple times
| @@ -102,8 +102,8 @@ def generate_nonce | |||
| end | |||
|
|
|||
| def extract_nonce(bytes) | |||
| nonce = bytes.slice!(0, nonce_bytes) | |||
There was a problem hiding this comment.
Was exceptionally bad when used with a database library which changes stuff as soon as you change a variable.
There was a problem hiding this comment.
@Asmod4n sorry you had to track this down. We shouldn't mutate inputs unless we have a type that's designed for that purpose (e.g. RbNaCl::Buffer)
|
Seems good |
tarcieri
added a commit
that referenced
this pull request
Feb 22, 2014
Allow RandomNonceBox to decrypt the same cipher text multiple times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cryptosphere/rbnacl/blob/master/lib/rbnacl/random_nonce_box.rb#L105 was preventing RandomNonceBox to open the same enciphered message multiple times