Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working when working from a parent DIR #193

Open
wJoenn opened this issue Mar 2, 2024 · 3 comments
Open

Not working when working from a parent DIR #193

wJoenn opened this issue Mar 2, 2024 · 3 comments
Assignees
Labels

Comments

@wJoenn
Copy link

wJoenn commented Mar 2, 2024

Describe the bug
Extension seems like it can't load properly unless my idea is currently opened on the crystal root dir.

  • Shards are marked as missing although they've been installed
  • Type hint on hover do not appear
  • Type errors do not appear

Opening the IDE in the Crystal dir instead of it's parent dir solves all the afore mentionned issues

To Reproduce
Move a crystal project in a parent directory

Screenshots
Error thrown saying jennifer is not installed
image

Type error not marked
image

Desktop (please complete the following information):

  • OS: Windows 10 + WSL2 Ubuntu22
  • Crystal version: v1.11.2
  • This plugin version: 0.9.3
@nobodywasishere
Copy link
Member

This extension is designed to work with crystal projects opened as the workspace root, and will take some work to make it more extensible. However, this should fix another issue with opening projects outside of the current project root (like files from stdlib) that currently run into issues. For now my recommendation is to use multi-root workspaces until this functionality is implemented. As well, there are some issues with WSL2 that I haven't had time to diagnose yet, as a heads up. Thank you!

@wJoenn
Copy link
Author

wJoenn commented Apr 3, 2024

Shall I close this ? (Sorry for the delay, I hadn't checked my notifications for a while)

@nobodywasishere
Copy link
Member

No - I'm currently implementing this functionality and should have it ready soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants