Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sponsor data and introduce small logo sponsors on homepage #740

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Mar 21, 2024

grafik

Original preview:
grafik

Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit 313cc53
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/660338e1ba5dd20008cdcb48
😎 Deploy Preview https://deploy-preview-740--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. We need to ensure the proper level, and get a confirmation with @jkicillof that the design on the home page is good with the new tier.

@@ -65,6 +65,8 @@ end
all_sponsors.sort_by! { |s| {-s.last_payment, -s.all_time, s.since, s.name} }

write_csv("sponsors.csv", all_sponsors)
write_csv("sponsor_logos_l.csv", all_sponsors.select { |sponsor| sponsor.last_payment.to_i > 1000 })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (might) need adjustment once we get the new levels.

@beta-ziliani beta-ziliani mentioned this pull request Mar 21, 2024
@jkicillof
Copy link
Collaborator

I don't get the new feature, there're already sponsor logos at home page design, are you planing to add another hierarchy?
image

@jkicillof
Copy link
Collaborator

jkicillof commented Mar 21, 2024

I didn't see the small logo in the preview 🤦‍♂️. I think we shouldn't have different logo sizes there. If we must do that I think we could add a badge to the best sponsors.

@straight-shoota
Copy link
Member Author

Yeah we want to differentiate the sponsor logos based on their contribution value. A single class of sponsor logo throws everything in one basket and we want more discrete options to offer better perks for higher sponsorship tiers. This is part of an ongoing revamp of sponsorship tiers.

Differentiating on the basis of logo size is a common means to represent sponsorsship tiers. Size increments communicate a clear hiearchical order intuitively. I don't think a badge can do that efficiently.

@ysbaddaden
Copy link

It's just the "works on arm" logo ain't the best logo for such a tiny size, unlike 84codes, Manas or Nikola ones, that would still fare well.

@straight-shoota
Copy link
Member Author

straight-shoota commented Mar 22, 2024

Yeah, perhaps we should increase the image size a bit to make it work better. We could consider skipping the text label then.

grafik

@jkicillof
Copy link
Collaborator

jkicillof commented Mar 22, 2024

I updated the sponsors section here. The logos on the second tier are smaller but not so much and they have less contrast.
image

@straight-shoota
Copy link
Member Author

I implemented these visuals keeping the same format but smaller logo size and lighter colors.

Getting the colors is a bit tricky, I'm using contrast and grayscale filters. It looks fine for the current set of logos.

Updated screenshot in the OP.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to new tiers

scripts/merge.cr Show resolved Hide resolved
scripts/merge.cr Outdated Show resolved Hide resolved
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changes are committed, this is good to go

"url": "https://developer.arm.com/solutions/infrastructure/works-on-arm",
"logo": "sponsors/woa.png",
"last_payment": 500,
"all_time": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, we're not listing the total, so there's no point in having this updated

@straight-shoota straight-shoota merged commit 348d0f0 into crystal-lang:relaunch-2023 Mar 26, 2024
5 checks passed
@straight-shoota straight-shoota deleted the refactor/sponsors-data branch March 26, 2024 21:08
@straight-shoota straight-shoota linked an issue Mar 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Relaunch] Missing CI sponsor
4 participants