-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sponsor data and introduce small logo sponsors on homepage #740
Refactor sponsor data and introduce small logo sponsors on homepage #740
Conversation
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good. We need to ensure the proper level, and get a confirmation with @jkicillof that the design on the home page is good with the new tier.
@@ -65,6 +65,8 @@ end | |||
all_sponsors.sort_by! { |s| {-s.last_payment, -s.all_time, s.since, s.name} } | |||
|
|||
write_csv("sponsors.csv", all_sponsors) | |||
write_csv("sponsor_logos_l.csv", all_sponsors.select { |sponsor| sponsor.last_payment.to_i > 1000 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (might) need adjustment once we get the new levels.
I didn't see the small logo in the preview 🤦♂️. I think we shouldn't have different logo sizes there. If we must do that I think we could add a badge to the best sponsors. |
Yeah we want to differentiate the sponsor logos based on their contribution value. A single class of sponsor logo throws everything in one basket and we want more discrete options to offer better perks for higher sponsorship tiers. This is part of an ongoing revamp of sponsorship tiers. Differentiating on the basis of logo size is a common means to represent sponsorsship tiers. Size increments communicate a clear hiearchical order intuitively. I don't think a badge can do that efficiently. |
It's just the "works on arm" logo ain't the best logo for such a tiny size, unlike 84codes, Manas or Nikola ones, that would still fare well. |
I updated the sponsors section here. The logos on the second tier are smaller but not so much and they have less contrast. |
I implemented these visuals keeping the same format but smaller logo size and lighter colors. Getting the colors is a bit tricky, I'm using contrast and grayscale filters. It looks fine for the current set of logos. Updated screenshot in the OP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to new tiers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the changes are committed, this is good to go
"url": "https://developer.arm.com/solutions/infrastructure/works-on-arm", | ||
"logo": "sponsors/woa.png", | ||
"last_payment": 500, | ||
"all_time": 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, we're not listing the total, so there's no point in having this updated
Original preview:
![grafik](https://private-user-images.githubusercontent.com/466378/315595092-512b67d1-5306-4e31-82c0-3e0c60eb872b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg5MDU3MTEsIm5iZiI6MTcxODkwNTQxMSwicGF0aCI6Ii80NjYzNzgvMzE1NTk1MDkyLTUxMmI2N2QxLTUzMDYtNGUzMS04MmMwLTNlMGM2MGViODcyYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyMFQxNzQzMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NWZhNmVmZDUxOWE5NTllYjVkYTg3ZjYwYzJlZDcyODcwNzY2ZmY2ZDliMTUwYWFiMmQ3MDYxZDkxMDQwMzFkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.sjThRj307u15EcHdZO5DZEviHHMLdqhkVUebMJl-02k)