Compiler: refactor and slightly optimize merging two types #12436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is easier to review by going over each commit. |
straight-shoota
approved these changes
Sep 6, 2022
caspiano
added a commit
to caspiano/crystal
that referenced
this pull request
Nov 1, 2022
…rystal-lang#12436)" This reverts commit bfc33db.
caspiano
added a commit
to caspiano/crystal
that referenced
this pull request
Nov 1, 2022
…types (crystal-lang#12436)"" This reverts commit 442daae.
straight-shoota
pushed a commit
that referenced
this pull request
Nov 2, 2022
beta-ziliani
pushed a commit
that referenced
this pull request
Nov 3, 2022
beta-ziliani
pushed a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a refactor so that two types can be merged without creating intermediate arrays in most cases. I need this refactor for some other things I have in mind.
It also includes some small optimizations to avoid creating intermediate arrays in some cases, but they aren't significant. Well, when compiling the compiler it seems this reduces the total amount of memory by 10MB, so I guess that's good 😄