Fix formatter on call without parentheses followed by doc comment #14354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `skip_space` would consume trailing comments, newlines and comments after newlines which on calls without parentheses. It would be fine to keep it when there are parentheses (because then we expect `OP_RPAREN`), but it seems to be entirely unnecessary.
straight-shoota
force-pushed
the
fix/formatter-trailing-comment-doc-comment
branch
from
11c2d2f
to
e4547ca
Compare
straight-shoota
changed the title
skip_space at end of Call
straight-shoota
changed the title
ysbaddaden
approved these changes
Mar 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
skip_spacewould consume trailing comments, newlines and comments after newlines which on calls without parentheses. It would be fine to keep it when there are parentheses (because then we expectOP_RPAREN), but it seems to be entirely unnecessary.Resolves #14286