Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hash#put_if_absent putting duplicate keys #14427

Merged
merged 1 commit into from Apr 4, 2024
Merged

Fix Hash#put_if_absent putting duplicate keys #14427

merged 1 commit into from Apr 4, 2024

Conversation

HertzDevil
Copy link
Contributor

Fixes #14425

straight-shoota
straight-shoota approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to see some significant code reduction. I guess it was good idea to optimize for the insert case specifically, but as we know now, that didn't work out.

@straight-shoota straight-shoota added this to the 1.12.0 milestone Apr 3, 2024
@straight-shoota straight-shoota merged commit 8ca32e8 into crystal-lang:master Apr 4, 2024
57 of 58 checks passed
@HertzDevil HertzDevil deleted the bug/hash-put-if-absent-duplicate branch April 5, 2024 18:11
@beta-ziliani beta-ziliani mentioned this pull request Apr 9, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:collection
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Hash#put_if_absent can put duplicate keys
3 participants
@HertzDevil @ysbaddaden @straight-shoota