Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP::Request multipart/form-data handling #1989

Closed
sdogruyol opened this issue Jan 2, 2016 · 4 comments
Closed

HTTP::Request multipart/form-data handling #1989

sdogruyol opened this issue Jan 2, 2016 · 4 comments

Comments

@sdogruyol
Copy link
Member

Currently we don't handle multipart forms and need to implement this for dealing with file uploads.

I'll try to do this according to Rack implementation https://github.com/rack/rack/tree/028438ffffd95ce1f6197d38c04fa5ea6a034a85/lib/rack/multipart

What do you think?

@sdogruyol
Copy link
Member Author

I checked a lot of implementations and i think that this should be handled outside of std. I'm going to create a shard soon.

@RX14
Copy link
Contributor

RX14 commented Jun 20, 2016

I would tend to disagree, if the standard library has room for websockets, it surely has room for multipart/form-data, which is arguably more fundamental to the web.

@RX14
Copy link
Contributor

RX14 commented Jul 7, 2016

Will be fixed by #2967, once complete.

@sdogruyol
Copy link
Member Author

This is living in a shard (https://github.com/RX14/multipart.cr) now thanks to @RX14 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants