Bug: union of Int32 and BigRational leads to Number

[vladfaust]

https://carc.in/#/r/2uh7

require "big_rational"

class Foo
  @foo = Hash(Symbol, Int32 | BigRational).new
end

Error in temp2.cr:4: instance variable '@foo' of Foo must be Hash(Symbol, Number), not (Hash(Symbol, BigRational | Int32) | Hash(Symbol, Number))

  @foo = Hash(Symbol, Int32 | BigRational).new
  ^~~~

$ crystal -v
Crystal 0.23.1 [e2a1389] (2017-07-13) LLVM 3.8.1

The hash is defined in macro as seen here, so I'm unable to unify types in one Number.

Related: onyxframework/sql#8

[RX14]

We typically add the PRs instead of the closed issues to the Next milestone @asterite. That way we track what code was actually merged instead of just the issues, when one PR might close multiple or introduce it's own side effect.

[asterite]

@RX14 Mmm... But when you browse the milestone you have no idea then what bugs were fixed.

[RX14]

@asterite PRs almost always have some mention or link of the issue they're related to. At the very least if they don't, the PR contains a description of the bug. We wouldn't know how to review a PR ourselves if we didn't know what it fixed.