Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for retrieval of descendant structs from hashed structures #5254

Merged
merged 2 commits into from Nov 7, 2017
Merged

Workaround for retrieval of descendant structs from hashed structures #5254

merged 2 commits into from Nov 7, 2017

Conversation

hinrik
Copy link
Contributor

@hinrik hinrik commented Nov 7, 2017

Resolves #5249.

RX14
RX14 requested changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a TODO which links to #5249.

# TODO: This is a workaround for https://github.com/crystal-lang/crystal/issues/5249

@RX14 RX14 added this to the Next milestone Nov 7, 2017
@RX14 RX14 merged commit ebf6006 into crystal-lang:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hinrik @asterite @RX14