You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey,
I was just patching SSL/TLS support into amqp.cr and it failed after calling socket.write() with a 0-length slice argument. The normal IO socket accepts this silently.
The error occurs in unbuffered_write:
Hey,
I was just patching SSL/TLS support into amqp.cr and it failed after calling
socket.write()
with a 0-length slice argument. The normal IO socket accepts this silently.The error occurs in
unbuffered_write
:crystal/src/openssl/ssl/socket.cr
Lines 107 to 116 in 7fb783f
because openssl will return an "unexpected EOF" if
count
== 0. (It might also just be returning a 0, because 0 bytes are written.. IDK)It would be nice if the behaviour was aligned with the standard socket, and it just succeeded after "writing" a 0-length buffer.
The text was updated successfully, but these errors were encountered: