Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font weight in Crystal Play #6753

Closed
proyb6 opened this issue Sep 20, 2018 · 4 comments
Closed

Font weight in Crystal Play #6753

proyb6 opened this issue Sep 20, 2018 · 4 comments
Labels
good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. kind:bug status:accepted topic:compiler topic:tools:playground topic:tools

Comments

@proyb6
Copy link

proyb6 commented Sep 20, 2018

I'm struggling to read "thin" font (font-weight: 200) and I'm sure many with bad vision will find it tough to read too. We could reset to normal font weight?

@bcardiff
Copy link
Member

You can change the font used in $ crystal play when using workbooks, not yet the whole style.
This is can be done since *.css files in a specific directory will be included automatically in workbooks. Maybe it would be good to include them in the whole playground also to offer a workaround.

Having better accessibility options by default is good. I tend to like lighter fonts when the information does not change, but is not a safe choice for everyone. So, 👍 for changing them.

Another lack of a11y would be to have night/light themes. Just two of them built under settings.

For using the workbooks with custom *.css you would need:

$ tree playground/
playground/
├── empty.md
└── resources
    └── font.css

empty.md

# Sample

```playground
puts "hello"
```

resources/font.css

html { font-weight: normal; }

Run $ crystal play and open http://localhost:8080/workbook/playground/empty or access it via de nav bar menu.

@proyb6
Copy link
Author

proyb6 commented Sep 20, 2018

Nice steps! Thanks.

@straight-shoota straight-shoota added the good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. label Feb 12, 2019
@Maroo-b
Copy link
Contributor

Maroo-b commented Mar 19, 2019

@bcardiff should we close this issue as the PR was merged, or do you guys keep it for tracking?

@bcardiff
Copy link
Member

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This is an issue suited for newcomers to become aquianted with working on the codebase. kind:bug status:accepted topic:compiler topic:tools:playground topic:tools
Projects
None yet
Development

No branches or pull requests

5 participants