Wrong error location for deprecated method usage inside macro

[leonklingele]

This seems to be an issue with the stdlib of Crystal which itself is using deprecated features.

$ crystal build --error-on-warnings src/invidious.cr
In /usr/share/crystal/src/object.cr:14:12
 14 | !(self == other)
             ^
Warning: Deprecated JSON::PullParser::Kind#==. JSON::PullParser#kind now is an enum, please use that instead of symbols
A total of 1 warnings were found.
The command "crystal build --error-on-warnings src/invidious.cr" failed and exited with 1 during .

See https://travis-ci.org/leonklingele/invidious/jobs/588639545#L247-L255

[leonklingele]

Issue was introduced in #7966.

[asterite]

The error message is probably wrong and should point to the location where the deprecated JSON::PullParser::Kind#== is called. It seems the full trace of the warning is not shown, otherwise it would point you to the correct location.

It seems the problem is this line: https://github.com/leonklingele/invidious/blob/8189dd3268572b695066196715ee4a77662de78a/src/invidious/helpers/patch_mapping.cr#L53

change it to:

    until %pull.kind.end_object?

and the warning will go away.

Sorry for the bad error message!

[leonklingele]

Thanks for helping @asterite :) This did indeed resolve the issue.
Is there an easy way to fix the misleading error message?

BTW: Building with --error-trace doesn't show where the actual problem is located either.

[asterite]

Not easy, it's a compiler bug. Maybe related to the fact that this happens inside a macro.

[leonklingele]

Shall I open a separate issue for this?

[asterite]

I think we can use this issue to track the problem