Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add the commit hash to the lock file #242

Open
j8r opened this issue Dec 4, 2018 · 4 comments
Open

Always add the commit hash to the lock file #242

j8r opened this issue Dec 4, 2018 · 4 comments

Comments

@j8r
Copy link
Contributor

j8r commented Dec 4, 2018

Now the commit hash isn't used when a version is specified.
If the maintainer of a library rebase or force-push a new commit, and then recreating a tag, we can end up with a untrustworthy/untested dependency without knowing it.
Having a commit hash along with the pinned version prevents this type of ninja changes.

@jhass
Copy link
Member

jhass commented May 25, 2020

#354 did implement this.

@jhass jhass closed this as completed May 25, 2020
@jhass
Copy link
Member

jhass commented May 25, 2020

Actually taking a second look at the code I'm not 100% confident about this anymore, @waj would you mind to confirm?

@jhass jhass reopened this May 25, 2020
@waj
Copy link
Member

waj commented May 25, 2020

@jhass correct, the hash is only stored as version metadata when using git references (branch, tag, commit). I'd like to use a slightly different mechanism so we could still differentiate the intention of the lock, and thus provide better error messages.

@jhass
Copy link
Member

jhass commented May 25, 2020

But I guess with #354 in place, validating the stored commit still matches the stored git tag or version should be pretty easy to do, would be great if you could keep that in mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants