Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"--no-color" is broken when "shards build" fails #508

Closed
evgkrsk opened this issue Jun 20, 2021 · 1 comment · Fixed by #517
Closed

"--no-color" is broken when "shards build" fails #508

evgkrsk opened this issue Jun 20, 2021 · 1 comment · Fixed by #517

Comments

@evgkrsk
Copy link

evgkrsk commented Jun 20, 2021

Bug Report

There is no difference if "--no-color" is present or absent in args during "shards build" failure:
image

BUT there is difference when compilation is successful:

image

❯ crystal -v
Crystal 1.0.0 (2021-03-22)

LLVM: 11.1.0
Default target: x86_64-apple-macosx

(ordinal "brew install crystal" on macOS BigSur 11.4, iMac 2020)
@oprypin oprypin transferred this issue from crystal-lang/crystal Jun 20, 2021
@oprypin
Copy link
Member

oprypin commented Jun 20, 2021

Yes, this report is true.

image

@straight-shoota straight-shoota mentioned this issue Jul 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pass no-color and verbose flags to crystal build straight-shoota/shards
2 participants
@evgkrsk @oprypin