Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous shard name source checker error message could be more helpful #590

Open
rmarronnier opened this issue Jul 8, 2023 · 0 comments

Comments

@rmarronnier
Copy link

rmarronnier commented Jul 8, 2023

Edit : after digging down, another dependency in my canonical shard.yml

  cable:
    github: cable-cr/cable

required

  redis:
    github: stefanwille/crystal-redis

Maybe the

Error shard name (redis) has ambiguous sources: 'git: https://github.com/jgaskins/redis.git' and 'git: https://github.com/stefanwille/crystal-redis.git'.

error message could list all the shard.yml files with conflicting shard name ?


Original issue :

A shards install using

dependencies:
  redis:
    github: jgaskins/redis

results in :

Error shard name (redis) has ambiguous sources: 'git: https://github.com/jgaskins/redis.git' and 'git: https://github.com/stefanwille/crystal-redis.git'.

Is this intended behaviour ?


Shards 0.17.3 [d75b004] (2023-04-07)

@rmarronnier rmarronnier changed the title Too strict ambiguous source checker Ambiguous shard name source checker error message could be more helpful Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants