Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create shard.yml.schema #622

Closed
nobodywasishere opened this issue Mar 6, 2024 · 1 comment · Fixed by #623
Closed

Create shard.yml.schema #622

nobodywasishere opened this issue Mar 6, 2024 · 1 comment · Fixed by #623
Labels
kind:feature

Comments

@nobodywasishere
Copy link
Contributor

It would be useful to provide a JSON schema for the shard.yml, allowing for IDE validation and documentation while editing the shard.yml. Ideally, this would then be added to JSON Schema Store for direct IDE support. I can implement this and create a PR if it would be accepted.
@straight-shoota
Copy link
Member

That would be really lovely. 😍

shard.lock and lib/.shards.info are also standardized YAML formats. However, they're only meant to be written automatically and not expected to be edited. So I suppose a schema wouldn't be much useful there.

@nobodywasishere nobodywasishere mentioned this issue Mar 7, 2024
Merged
@straight-shoota straight-shoota linked a pull request Apr 2, 2024 that will close this issue
Add JSON schema for shard.yml #623
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add JSON schema for shard.yml nobodywasishere/shards
2 participants
@straight-shoota @nobodywasishere