Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI's pylint speed #1084

Closed
montyly opened this issue Mar 5, 2022 · 1 comment · Fixed by #1088
Closed

Fix CI's pylint speed #1084

montyly opened this issue Mar 5, 2022 · 1 comment · Fixed by #1088
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@montyly
Copy link
Member

montyly commented Mar 5, 2022

It looks like pylint is taking 20-30 min to run through the github super linter. We have to investigate why it happens, and how we can speed this up

@montyly montyly added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 5, 2022
@elopez
Copy link
Member

elopez commented Mar 5, 2022

It looks like super linter collects a list of files and then goes through them to split the list into the different kinds of linters. This is done in a shell script. Then it runs them one by one through the linting programs.

The repository has close to ~13k files, of which 12.5k are tests/*, ~11.7k tests/ast-parsing/*, ~12.4k are sol/json/zip in tests/*

I feel it would be overall faster to just pip install black & pylint and run those directly in the workflow on the full project, and keep the super linter for the non-python bits.

@montyly montyly closed this as completed in 024b884 Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants