[Bug]: all statements with . are reported as external calls

[mds1]

Describe the issue:

I ran slither . --print function-summary to view external calls for functions. The resulting "External Calls" column treats any statement with a . as an external call. This includes solidity built-ins like abi.encode, library accesses like Address.sendValue, and struct field accesses.

Code example to reproduce the issue:

git clone https://github.com/scopelift/pooltogether-governor-upgrade/
cd pooltogether-governor-upgrade
forge install
slither . --print function-summary

Version:

0.9.6

Relevant log output:

No response

[0xalpharush]

Instead of using all call expressions (which include members like abi.encode), we should use the expression of the HighLevelCall filtered from all the operations (https://crytic.github.io/slither/slither/core/declarations/function.html#Function.all_slithir_operations)

slither/slither/core/declarations/function_contract.py

Line 116 in fdf54f6

[str(x) for x in self.external_calls_as_expressions],

EDIT: What external_calls_as_expressions returns seems wrong as the comment says it should be calls which create a message (new call frame). Instead I think it would work to filter out SolidityVariable here

slither/slither/vyper_parsing/cfg/node.py

Line 62 in fdf54f6

c for c in self._node.calls_as_expression if not isinstance(c.called, Identifier)

slither/slither/solc_parsing/yul/parse_yul.py

Line 95 in fdf54f6

c for c in self._node.calls_as_expression if not isinstance(c.called, Identifier)

slither/slither/solc_parsing/cfg/node.py

Line 66 in fdf54f6

c for c in self._node.calls_as_expression if not isinstance(c.called, Identifier)