Incorrect detector results to investigate

[montyly]

From @pcaversaccio

1

• Detector arbitrary-send-eth is correctly found here: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L159
• But it doesn't detect it here: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L374 and here https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L694

2

• The same line allows actually for reentrancy: https://github.com/pcaversaccio/createx/blob/62c04b1f614b3dbe577980fa761de0fe132e0613/src/CreateX.sol#L159 but it doesn't get detected (I only exclude reentrancy-events in the config)

[0xalpharush]

For 2, there isn't a state variable written after the call that's read before the call or in other functions

[pcaversaccio]

For 2, there isn't a state variable written after the call that's read before the call or in other functions

But I can reenter the function or any other function (cross-function reentrancy). So Slither doesn't care about this general reentrancy?

[0xalpharush]

What is the exploit? Here, it seems benign to call the functions reentrantly as it'd have the same affect as calling it twice, right? I'm not sure one would do except add nonreetrant modifiers on any function that makes an external call.

[pcaversaccio]

What is the exploit? Here, it seems benign to call the functions reentrantly as it'd have the same affect as calling it twice, right? I'm not sure one would do except add nonreetrant modifiers on any function that makes an external call.

There is no exploit for this case, I was just wondering whether this could lead to false negatives. Does Slither detect cross-function reentrancies?

[0xalpharush]

I think it depends on the case. The update in #1351 considered read/writes in reentrant functions, but we need better insight into this as highlighted in #1840. It'd be great to know of frequent, high impact cases we are missing

[pcaversaccio]

Right, what about 1) above? Why is this not discovered?