Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop() function in Inline assembly calls is treated as solidity functions #742

Closed
vanruch opened this issue Dec 28, 2020 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@vanruch
Copy link

vanruch commented Dec 28, 2020

When trying to analyze contract that contains code like this

assembly {
  ...
  stop()
  ...
}

I'm getting the following error when name = stop().

File "/home/ethsec/.local/lib/python3.6/site-packages/slither/core/declarations/solidity_variables.py", line 154, in __init__
    assert name in SOLIDITY_FUNCTIONS

Maybe stop should be added to evm_functions.py list?

@vanruch vanruch changed the title stop() function in Inline assembly calls is treated as solidity functions stop() function in Inline assembly calls is treated as solidity functions Dec 28, 2020
@montyly
Copy link
Member

montyly commented Jan 4, 2021

Hi @vanruch, thank you for reporting this. We will fix it

@montyly montyly added the bug Something isn't working label Jan 4, 2021
@montyly montyly mentioned this issue Feb 16, 2021
11 tasks
@montyly montyly closed this as completed in 28da1ad Mar 7, 2021
@montyly
Copy link
Member

montyly commented Mar 7, 2021

Hi @vanruch

We added the support in master. The fix will be available in the upcoming 0.7.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants