Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the network architecture. #10

Open
xjw00654 opened this issue Jul 15, 2020 · 2 comments
Open

About the network architecture. #10

xjw00654 opened this issue Jul 15, 2020 · 2 comments

Comments

@xjw00654
Copy link

I noticed the code in the net.py and found the features[variable: prs] extracted by the Prior Estimation Network is not concatenated with the features extracted by the Coarse SR network. It seems like the pipeline in this code is Coarse -> Fine SR Enc -> Fine SR Dec which leaves the Prior Estimation Network as a independent module.

It is a little different from what illustated in the Figure2 in the FSRNet paper. Is there any mistakes or my mis-understanding?

# net.py -- FSRNet
def forward(self, x):
    y_c = self.csr_net(x)
    f = self.fsr_enc(y_c)
    p = self.pre_net(y_c)

    # 1x1 conv for hmaps & pmaps
    b1 = (self.prior_conv1 is not None)
    b2 = (self.prior_conv2 is not None)
    if b1 and b2:
        hmaps = self.prior_conv1(p)
        pmaps = self.prior_conv2(p)
        prs = torch.cat((hmaps, pmaps), 1)
    elif b1:
        prs = self.prior_conv1(p)
    elif b2:
        prs = self.prior_conv2(p)

    # HERE
    concat = torch.cat((f, p), 1)
    # HERE 

    out = self.fsr_dec(concat)
    return y_c, prs, out
@cs-giung
Copy link
Owner

O__O

@cs-giung
Copy link
Owner

cs-giung commented Jul 15, 2020

You're right. prs should be used.

@cs-giung cs-giung pinned this issue Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants