Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolynomialFeatures constructor is called with the wrong degree #8

Open
covuworie opened this issue Jun 26, 2018 · 0 comments
Open

PolynomialFeatures constructor is called with the wrong degree #8

covuworie opened this issue Jun 26, 2018 · 0 comments

Comments

@covuworie
Copy link

I have seen a bug in the section Cross Validation: For Selecting Polynomial Model Degree of Lecture_6_Notebook.ipynb. The degree d is incorrectly used in the PolynomialFeatures constructor. This has a value of 19 which is the last index of the previous loop. The intention is to use the degree with the best cross-validation score so the code should read:

gen_poly_terms = PolynomialFeatures(degree=best_degree, interaction_only=False)

PS: Likewise, I have not submitted a pull request for this as you may not want the output produced from my notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant