Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Stop execution #38

Closed
jcruz opened this issue Apr 13, 2018 · 5 comments
Closed

[feature] Stop execution #38

jcruz opened this issue Apr 13, 2018 · 5 comments
Assignees
@jcruz
Labels
feature New feature or request
Projects
Coconut Interpreter
Milestone
Phase 4; 2nd Mile...

Comments

@jcruz
Copy link
Contributor

jcruz commented Apr 13, 2018 •
edited

Be able to cancel a current request before the 30 second timeout.

https://redux-saga.js.org/docs/advanced/TaskCancellation.html
redux-saga/redux-saga#651
@jcruz jcruz added the feature New feature or request label Apr 13, 2018
@jcruz jcruz added this to the Phase 3; 2nd Milestone milestone Apr 13, 2018
@jcruz jcruz added this to To do in Coconut Interpreter via automation Apr 13, 2018
@mjenrungrot
Copy link

How are we going to handle the backend? And, do we need specific error messages if we stop the execution early?

@jcruz
Copy link
Contributor Author

jcruz commented Apr 13, 2018

It may be bad practice, but we'll just let the backend run into the timeout since I don't think it's possible to easily kill/timeout the exec command. I think there shouldn't be an error message since the user stopped it.

@mjenrungrot
Copy link

I think at the moment the backend does not have any timeout, right? It just has the timeout on AWS Lambda but not local server.

@jcruz
Copy link
Contributor Author

jcruz commented Apr 14, 2018

Yup only thinking about production

@jcruz jcruz self-assigned this Apr 16, 2018
@jcruz jcruz mentioned this issue Apr 18, 2018
Closed
@jcruz
Copy link
Contributor Author

jcruz commented Apr 18, 2018

Moved to cs121-team-panda/coconut-interpreter#87

@jcruz jcruz closed this as completed Apr 18, 2018
Coconut Interpreter automation moved this from To do to Done Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcruz jcruz

Labels
feature New feature or request
Projects
Coconut Interpreter
  
Done
Milestone
Phase 4; 2nd Milestone
Development

No branches or pull requests
2 participants
@jcruz @mjenrungrot